Support Remix Single Fetch in @shopify/oxygen-remix

[chinanderm]

What is the location of your example repository?

No response

Which package or tool is having this issue?

Oxygen

What version of that package or tool are you using?

@shopify/[email protected]

What version of Remix are you using?

2.13.1

Steps to Reproduce

Follow the Single Fetch migration docs from Remix and...

Turn on v3_singleFetch in Remix config:

{
  // ...
  v3_singleFetch: true
  // ...
}

Enable the TS behavior for Single Fetch:

declare module "@shopify/remix-oxygen" {
  interface Future {
    v3_singleFetch: true;
  }
}

Update json() usage with data():

import { data, type LoaderFunctionArgs } from '@shopify/remix-oxygen'

export async function loader({}: LoaderFunctionArgs) {
  const headers = new Headers()

  // ...

  return data({ ... }, { headers })
}

// ...

Expected Behavior

• @shopify/remix-oxygen exports interface Future from @remix-run/server-runtime so it can be appended to using declare module
• @shopify/remix-oxygen exports data() function from @remix-run/server-runtime so it can be used in place of json()

Actual Behavior

• @shopify/remix-oxygen does not export interface Future from @remix-run/server-runtime, thus it cannot be appended to using declare module
• @shopify/remix-oxygen does not export data() function from @remix-run/server-runtime, thus it cannot be used in place of json()

[chinanderm]

I forked this repo and made what I believe to be the only needed change to support Single Fetch. See: chinanderm@4cf7a87

[wizardlyhel]

You should be able to just import those 2 missing exports from @remix-run/server-runtime. @shopify/remix-oxygen only had to implement createRequestHandler.

We still need some time to turn on single fetch

[chinanderm]

Thanks @wizardlyhel!

We still need some time to turn on single fetch

Just to confirm — we shouldn't be deploying Single Fetch code to production yet with Hydrogen/Oxygen?

[wizardlyhel]

That's correct - There a couple things we had to do in order to support single fetch.

[michael-land]

'defer' is now marked as deprecated in 2.14.0

[kwtech-dev]

Can we keep this issue open? It seems that "Support Remix Single Fetch" is not completed yet