Fix CLI version detection to use package.json instead of constant

- Replace CLI_KIT_VERSION constant with cliVersion() function
- Read version dynamically from package.json at runtime
- Add isMajorVersionChange helper function
- Remove bin/update-cli-kit-version.js (no longer needed)
- Update .github/workflows/release.yml validation message
- Update bin/release to remove update-cli-kit-version.js call
- Update package.json changeset-manifests script
- Update all imports across the codebase

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: gonzaloriestra

.github/workflows/release.yml

@@ -66,7 +66,7 @@ jobs:
           comment_suffix: "
             > [!CAUTION]
 
-            > After installing, validate the version by running just `shopify` in your terminal.
+            > After installing, validate the version by running `shopify version` in your terminal.
 
             > If the versions don't match, you might have multiple global instances installed.
 

bin/release

@@ -16,7 +16,6 @@ fi
 if [ "$tag" = "nightly" ] || [ "$tag" = "experimental" ]; then
   echo -e "---\n'"'@shopify/cli'"': patch\n---" > .changeset/force-release.md
   pnpm changeset version --snapshot $tag
-  ./bin/update-cli-kit-version.js
 fi
 
 # Bundle the packages

bin/update-cli-kit-version.js

@@ -8,7 +8,7 @@
     "build:affected": "nx affected --target=build",
     "build": "nx run-many --target=build --all --skip-nx-cache",
     "bundle-for-release": "nx run-many --target=bundle --all --skip-nx-cache",
-    "changeset-manifests": "changeset version && pnpm install --no-frozen-lockfile && pnpm refresh-manifests && pnpm refresh-readme && pnpm refresh-code-documentation && bin/update-cli-kit-version.js",
+    "changeset-manifests": "changeset version && pnpm install --no-frozen-lockfile && pnpm refresh-manifests && pnpm refresh-readme && pnpm refresh-code-documentation",
     "clean": "nx run-many --target=clean --all --skip-nx-cache && nx reset",
     "create-app": "nx build create-app && node packages/create-app/bin/dev.js --package-manager npm",
     "deploy-experimental": "node bin/deploy-experimental.js",

package.json

@@ -4,7 +4,7 @@ import {filterCustomHeaders} from './utilities.js'
 import express from 'express'
 import bodyParser from 'body-parser'
 import {performActionWithRetryAfterRecovery} from '@shopify/cli-kit/common/retry'
-import {CLI_KIT_VERSION} from '@shopify/cli-kit/common/version'
+import {cliVersion} from '@shopify/cli-kit/node/version'
 import {AbortError} from '@shopify/cli-kit/node/error'
 import {adminUrl, supportedApiVersions} from '@shopify/cli-kit/node/api/admin'
 import {fetch} from '@shopify/cli-kit/node/http'
@@ -195,7 +195,7 @@ export function setupGraphiQLServer({
           Accept: 'application/json',
           'Content-Type': 'application/json',
           'X-Shopify-Access-Token': await token(),
-          'User-Agent': `ShopifyCLIGraphiQL/${CLI_KIT_VERSION}`,
+          'User-Agent': `ShopifyCLIGraphiQL/${cliVersion()}`,
         }
 
         return fetch(graphqlUrl, {

packages/app/src/cli/services/dev/graphiql/server.ts

@@ -15,7 +15,7 @@ import {
   stringifyMessage,
 } from '@shopify/cli-kit/node/output'
 import {AlertCustomSection, InlineToken} from '@shopify/cli-kit/node/ui'
-import {CLI_KIT_VERSION} from '@shopify/cli-kit/common/version'
+import {cliVersion} from '@shopify/cli-kit/node/version'
 
 export type Format = 'json' | 'text'
 export interface InfoOptions {
@@ -265,7 +265,7 @@ class AppInfo {
   async systemInfoSection(): Promise<AlertCustomSection> {
     const {platform, arch} = platformAndArch()
     return this.tableSection('Tooling and System', [
-      ['Shopify CLI', CLI_KIT_VERSION],
+      ['Shopify CLI', cliVersion()],
       ['Package manager', this.app.packageManager],
       ['OS', `${platform}-${arch}`],
       ['Shell', process.env.SHELL ?? 'unknown'],

packages/app/src/cli/services/info.ts

@@ -7,7 +7,7 @@ import {platform} from 'os'
 
 vi.mock('os')
 vi.mock('@shopify/cli-kit/node/node-package-manager')
-vi.mock('@shopify/cli-kit/common/version', () => ({CLI_KIT_VERSION: '1.2.3'}))
+vi.mock('@shopify/cli-kit/node/version', () => ({cliVersion: () => '1.2.3'}))
 
 describe('updateCLIDependencies', () => {
   test('updates @shopify/cli and deletes @shopify/app if not using global CLI', async () => {

packages/app/src/cli/services/init/template/npm.test.ts

@@ -1,7 +1,7 @@
 import {PackageManager, installNodeModules, PackageJson} from '@shopify/cli-kit/node/node-package-manager'
 import {moduleDirectory, normalizePath} from '@shopify/cli-kit/node/path'
 import {findPathUp} from '@shopify/cli-kit/node/fs'
-import {CLI_KIT_VERSION} from '@shopify/cli-kit/common/version'
+import {cliVersion} from '@shopify/cli-kit/node/version'
 import {platform} from 'os'
 
 interface UpdateCLIDependenciesOptions {
@@ -20,7 +20,7 @@ export async function updateCLIDependencies({
   if (useGlobalCLI) {
     delete packageJSON.dependencies['@shopify/cli']
   } else {
-    packageJSON.dependencies['@shopify/cli'] = CLI_KIT_VERSION
+    packageJSON.dependencies['@shopify/cli'] = cliVersion()
   }
 
   delete packageJSON.dependencies['@shopify/app']

packages/app/src/cli/services/init/template/npm.ts

@@ -33,7 +33,7 @@ import {CreateAssetUrl} from '../../api/graphql/app-management/generated/create-
 import {SourceExtension} from '../../api/graphql/app-management/generated/types.js'
 import {ListOrganizations} from '../../api/graphql/business-platform-destinations/generated/organizations.js'
 import {describe, expect, test, vi, beforeEach} from 'vitest'
-import {CLI_KIT_VERSION} from '@shopify/cli-kit/common/version'
+import {cliVersion} from '@shopify/cli-kit/node/version'
 import {fetch} from '@shopify/cli-kit/node/http'
 import {
   businessPlatformOrganizationsRequest,
@@ -69,7 +69,7 @@ const templateDisallowedByMinimumCliVersion: GatedExtensionTemplate = {
   ...testRemoteExtensionTemplates[2]!,
   organizationBetaFlags: ['allowedFlag'],
   // minimum CLI version is higher than the current CLI version
-  minimumCliVersion: `1${CLI_KIT_VERSION}`,
+  minimumCliVersion: `1${cliVersion()}`,
 }
 const templateDisallowedByDeprecatedFromCliVersion: GatedExtensionTemplate = {
   ...testRemoteExtensionTemplates[2]!,

packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts

@@ -161,15 +161,14 @@ import {
   businessPlatformRequestDoc,
   BusinessPlatformRequestOptions,
 } from '@shopify/cli-kit/node/api/business-platform'
-import {CLI_KIT_VERSION} from '@shopify/cli-kit/common/version'
+import {cliVersion, isPreReleaseVersion} from '@shopify/cli-kit/node/version'
 import {versionSatisfies} from '@shopify/cli-kit/node/node-package-manager'
 import {outputDebug} from '@shopify/cli-kit/node/output'
 import {developerDashboardFqdn, normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
 import {TokenItem} from '@shopify/cli-kit/node/ui'
 import {functionsRequestDoc, FunctionsRequestOptions} from '@shopify/cli-kit/node/api/functions'
 import {fileExists, readFile} from '@shopify/cli-kit/node/fs'
 import {JsonMapType} from '@shopify/cli-kit/node/toml'
-import {isPreReleaseVersion} from '@shopify/cli-kit/node/version'
 import {UnauthorizedHandler} from '@shopify/cli-kit/node/api/graphql'
 import {Variables} from 'graphql-request'
 import {webhooksRequestDoc, WebhooksRequestOptions} from '@shopify/cli-kit/node/api/webhooks'
@@ -1318,7 +1317,7 @@ export async function allowedTemplates(
   templates: GatedExtensionTemplate[],
   betaFlagsFetcher: (betaFlags: string[]) => Promise<{[key: string]: boolean}>,
   expFlagsFetcher: (expFlags: string[]) => Promise<{[key: string]: boolean}>,
-  version: string = CLI_KIT_VERSION,
+  version: string = cliVersion(),
 ): Promise<GatedExtensionTemplate[]> {
   // Extract both types of flags from templates
   const allBetaFlags = Array.from(new Set(templates.map((ext) => ext.organizationBetaFlags ?? []).flat()))