chore: resolve remaining switch-exhaustiveness-check warnings

isaacroldan · Claude Code · isaacroldan · commit 5d67093cb587 · 2026-03-27T11:37:18.000+01:00
Fix all 20 remaining eslint warnings (switch-exhaustiveness-check):

- fqdn.ts: file-level suppress — all switches branch on 'local' vs default
  (production). Tests mock serviceEnvironment() returning undefined, so
  explicit enum cases break tests.
- scopes.ts: add explicit 'admin'|'storefront-renderer' cases that throw
- output.ts: add missing 'silent' case to logLevelValue
- tree-kill.ts: suppress — default handles all Unix-like platforms
- mkcert.ts: suppress — default throws for unsupported platforms
- Logs.tsx: replace default with explicit BackgroundExecutionReason.Unknown
- execute-bulk-operation.ts: replace default with explicit error status cases
- format-bulk-operation-status.ts: replace default with explicit status cases
- extension.ts: replace default with explicit undefined|liquid|config-only
- declarative-definitions.ts: replace defaults with explicit GraphQL enum cases
- extension-config-builder.ts: replace default with explicit undefined case,
  use ?? instead of || for context fallback chain

Combined with the parent PR, this brings the codebase from 107 warnings to 0.

Co-authored-by: Claude Code &lt;claude-code@anthropic.com&gt;
diff --git a/nx.json b/nx.json
@@ -1,41 +1,25 @@
 {
   "targetDefaults": {
     "clean": {
-      "dependsOn": [
-        "^clean"
-      ]
+      "dependsOn": ["^clean"]
     },
     "build": {
-      "dependsOn": [
-        "^build"
-      ],
-      "inputs": [
-        "production",
-        "^production"
-      ]
+      "dependsOn": ["^build"],
+      "inputs": ["production", "^production"]
     },
     "refresh-manifests": {
-      "dependsOn": [
-        "build",
-        "refresh-readme"
-      ]
+      "dependsOn": ["build", "refresh-readme"]
     },
     "refresh-readme": {
-      "dependsOn": [
-        "build"
-      ]
+      "dependsOn": ["build"]
     },
     "lint": {},
     "lint:fix": {},
     "type-check": {
-      "dependsOn": [
-        "^build"
-      ]
+      "dependsOn": ["^build"]
     },
     "bundle": {
-      "dependsOn": [
-        "build"
-      ]
+      "dependsOn": ["build"]
     }
   },
   "extends": "@nx/workspace/presets/npm.json",
@@ -65,16 +49,12 @@
   "defaultBase": "main",
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
   "namedInputs": {
-    "default": [
-      "{projectRoot}/**/*",
-      "sharedGlobals"
-    ],
+    "default": ["{projectRoot}/**/*", "sharedGlobals"],
     "sharedGlobals": [],
-    "production": [
-      "default"
-    ]
+    "production": ["default"]
   },
   "tui": {
     "autoExit": true
-  }
+  },
+  "analytics": false
 }
diff --git a/packages/app/src/cli/services/app-logs/logs-command/ui/components/Logs.tsx b/packages/app/src/cli/services/app-logs/logs-command/ui/components/Logs.tsx
@@ -30,7 +30,7 @@ const getBackgroundExecutionReasonMessage = (reason: BackgroundExecutionReason):
       return 'No cached response available'
     case BackgroundExecutionReason.CacheAboutToExpire:
       return 'Cache is about to expire'
-    default:
+    case BackgroundExecutionReason.Unknown:
       return 'Unknown reason'
   }
 }
diff --git a/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts b/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts
@@ -212,7 +212,10 @@ async function renderBulkOperationResult(operation: BulkOperation, outputFile?:
         renderSuccess({headline, customSections})
       }
       break
-    default:
+    case 'CANCELED':
+    case 'CANCELING':
+    case 'EXPIRED':
+    case 'FAILED':
       renderError({headline, customSections})
       break
   }
diff --git a/packages/app/src/cli/services/bulk-operations/format-bulk-operation-status.ts b/packages/app/src/cli/services/bulk-operations/format-bulk-operation-status.ts
@@ -90,7 +90,9 @@ export function formatBulkOperationCancellationResult(
         renderType: 'warning',
       }
     }
-    default:
+    case 'CREATED':
+    case 'EXPIRED':
+    case 'RUNNING':
       return {
         headline,
         renderType: 'info',
diff --git a/packages/app/src/cli/services/generate/extension.ts b/packages/app/src/cli/services/generate/extension.ts
@@ -57,7 +57,9 @@ function getTemplateLanguage(flavor: ExtensionFlavorValue | undefined): Template
     case 'rust':
     case 'wasm':
       return flavor
-    default:
+    case undefined:
+    case 'liquid':
+    case 'config-only':
       return undefined
   }
 }
diff --git a/packages/app/src/cli/services/generate/shop-import/declarative-definitions.ts b/packages/app/src/cli/services/generate/shop-import/declarative-definitions.ts
@@ -710,7 +710,12 @@ function graphQLToAdminAccess(
   switch (access) {
     case 'MERCHANT_READ_WRITE':
       return 'merchant_read_write'
-    default:
+    case 'MERCHANT_READ':
+    case 'PRIVATE':
+    case 'PUBLIC_READ':
+    case 'PUBLIC_READ_WRITE':
+    case null:
+    case undefined:
       return undefined
   }
 }
@@ -721,7 +726,9 @@ function graphQLToStorefrontAccess(
   switch (access) {
     case 'PUBLIC_READ':
       return 'public_read'
-    default:
+    case 'NONE':
+    case null:
+    case undefined:
       return undefined
   }
 }
@@ -734,7 +741,9 @@ function graphQLToCustomerAccountAccess(
       return 'read'
     case 'READ_WRITE':
       return 'read_write'
-    default:
+    case 'NONE':
+    case null:
+    case undefined:
       return undefined
   }
 }
diff --git a/packages/app/src/cli/services/payments/extension-config-builder.ts b/packages/app/src/cli/services/payments/extension-config-builder.ts
@@ -97,6 +97,7 @@ export function buildExtensionConfig(extension: ExtensionRegistration, allExtens
         allExtensions,
         cardPresentDeployConfigToCLIConfig,
       )
+    case undefined:
     default:
       throw new Error(`Unsupported extension: ${context}`)
   }
diff --git a/packages/app/src/cli/utilities/mkcert.ts b/packages/app/src/cli/utilities/mkcert.ts
@@ -58,6 +58,7 @@ async function getMkcertPath(
 async function downloadMkcert(targetPath: string, platform: NodeJS.Platform, arch: NodeJS.Architecture): Promise<void> {
   let assetName: string
 
+  // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check -- default throws for unsupported platforms
   switch (platform) {
     case 'darwin':
       assetName = arch === 'arm64' ? `mkcert-${MKCERT_VERSION}-darwin-arm64` : `mkcert-${MKCERT_VERSION}-darwin-amd64`
diff --git a/packages/cli-kit/src/private/node/session/scopes.ts b/packages/cli-kit/src/private/node/session/scopes.ts
@@ -38,7 +38,8 @@ export function tokenExchangeScopes(api: API): string[] {
       return [scopeTransform('app-management')]
     case 'business-platform':
       return [scopeTransform('destinations')]
-    default:
+    case 'admin':
+    case 'storefront-renderer':
       throw new BugError(`API not supported for token exchange: ${api}`)
   }
 }
diff --git a/packages/cli-kit/src/public/node/context/fqdn.ts b/packages/cli-kit/src/public/node/context/fqdn.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/switch-exhaustiveness-check -- all switches branch on Environment.Local vs default (production) */
 import {AbortError} from '../error.js'
 import {serviceEnvironment} from '../../../private/node/context/service.js'
 import {DevServer, DevServerCore} from '../vendor/dev_server/index.js'
diff --git a/packages/cli-kit/src/public/node/output.ts b/packages/cli-kit/src/public/node/output.ts
@@ -194,8 +194,8 @@ function logLevelValue(level: LogLevel): number {
       return 50
     case 'fatal':
       return 60
-    default:
-      return 30
+    case 'silent':
+      return 70
   }
 }
 
diff --git a/packages/cli-kit/src/public/node/tree-kill.ts b/packages/cli-kit/src/public/node/tree-kill.ts
@@ -69,6 +69,7 @@ function adaptedTreeKill(
   const pidsToProcess = new Set<string>()
   pidsToProcess.add(rootPid)
 
+  // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check -- default handles all Unix-like platforms
   switch (process.platform) {
     case 'win32':
       // @ts-ignore
@@ -87,7 +88,6 @@ function adaptedTreeKill(
         },
       )
       break
-    // Linux
     default:
       buildProcessTree(
         rootPid,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ const getBackgroundExecutionReasonMessage = (reason: BackgroundExecutionReason):`
`30`	`30`	`return 'No cached response available'`
`31`	`31`	`case BackgroundExecutionReason.CacheAboutToExpire:`
`32`	`32`	`return 'Cache is about to expire'`
`33`		`- default:`
	`33`	`+ case BackgroundExecutionReason.Unknown:`
`34`	`34`	`return 'Unknown reason'`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,10 @@ async function renderBulkOperationResult(operation: BulkOperation, outputFile?:`
`212`	`212`	`renderSuccess({headline, customSections})`
`213`	`213`	`}`
`214`	`214`	`break`
`215`		`- default:`
	`215`	`+ case 'CANCELED':`
	`216`	`+ case 'CANCELING':`
	`217`	`+ case 'EXPIRED':`
	`218`	`+ case 'FAILED':`
`216`	`219`	`renderError({headline, customSections})`
`217`	`220`	`break`
`218`	`221`	`}`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,9 @@ export function formatBulkOperationCancellationResult(`
`90`	`90`	`renderType: 'warning',`
`91`	`91`	`}`
`92`	`92`	`}`
`93`		`- default:`
	`93`	`+ case 'CREATED':`
	`94`	`+ case 'EXPIRED':`
	`95`	`+ case 'RUNNING':`
`94`	`96`	`return {`
`95`	`97`	`headline,`
`96`	`98`	`renderType: 'info',`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,9 @@ function getTemplateLanguage(flavor: ExtensionFlavorValue \| undefined): Template`
`57`	`57`	`case 'rust':`
`58`	`58`	`case 'wasm':`
`59`	`59`	`return flavor`
`60`		`- default:`
	`60`	`+ case undefined:`
	`61`	`+ case 'liquid':`
	`62`	`+ case 'config-only':`
`61`	`63`	`return undefined`
`62`	`64`	`}`
`63`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,12 @@ function graphQLToAdminAccess(`
`710`	`710`	`switch (access) {`
`711`	`711`	`case 'MERCHANT_READ_WRITE':`
`712`	`712`	`return 'merchant_read_write'`
`713`		`- default:`
	`713`	`+ case 'MERCHANT_READ':`
	`714`	`+ case 'PRIVATE':`
	`715`	`+ case 'PUBLIC_READ':`
	`716`	`+ case 'PUBLIC_READ_WRITE':`
	`717`	`+ case null:`
	`718`	`+ case undefined:`
`714`	`719`	`return undefined`
`715`	`720`	`}`
`716`	`721`	`}`
`@@ -721,7 +726,9 @@ function graphQLToStorefrontAccess(`
`721`	`726`	`switch (access) {`
`722`	`727`	`case 'PUBLIC_READ':`
`723`	`728`	`return 'public_read'`
`724`		`- default:`
	`729`	`+ case 'NONE':`
	`730`	`+ case null:`
	`731`	`+ case undefined:`
`725`	`732`	`return undefined`
`726`	`733`	`}`
`727`	`734`	`}`
`@@ -734,7 +741,9 @@ function graphQLToCustomerAccountAccess(`
`734`	`741`	`return 'read'`
`735`	`742`	`case 'READ_WRITE':`
`736`	`743`	`return 'read_write'`
`737`		`- default:`
	`744`	`+ case 'NONE':`
	`745`	`+ case null:`
	`746`	`+ case undefined:`
`738`	`747`	`return undefined`
`739`	`748`	`}`
`740`	`749`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ export function buildExtensionConfig(extension: ExtensionRegistration, allExtens`
`97`	`97`	`allExtensions,`
`98`	`98`	`cardPresentDeployConfigToCLIConfig,`
`99`	`99`	`)`
	`100`	`+ case undefined:`
`100`	`101`	`default:`
`101`	`102`	throw new Error(`Unsupported extension: ${context}`)
`102`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ export function tokenExchangeScopes(api: API): string[] {`
`38`	`38`	`return [scopeTransform('app-management')]`
`39`	`39`	`case 'business-platform':`
`40`	`40`	`return [scopeTransform('destinations')]`
`41`		`- default:`
	`41`	`+ case 'admin':`
	`42`	`+ case 'storefront-renderer':`
`42`	`43`	throw new BugError(`API not supported for token exchange: ${api}`)
`43`	`44`	`}`
`44`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable @typescript-eslint/switch-exhaustiveness-check -- all switches branch on Environment.Local vs default (production) */`
`1`	`2`	`import {AbortError} from '../error.js'`
`2`	`3`	`import {serviceEnvironment} from '../../../private/node/context/service.js'`
`3`	`4`	`import {DevServer, DevServerCore} from '../vendor/dev_server/index.js'`