feat: fetch experience field from API instead of hardcoding it

isaacroldan · Claude Code · isaacroldan · commit 24d4b5237d8e · 2026-03-23T13:08:18.000+01:00
Co-authored-by: Claude Code &lt;claude-code@anthropic.com&gt;
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/active-app-release-from-api-key.ts b/packages/app/src/cli/api/graphql/app-management/generated/active-app-release-from-api-key.ts
@@ -24,7 +24,7 @@ export type ActiveAppReleaseFromApiKeyQuery = {
           handle: string
           config: JsonMapType
           target?: string | null
-          specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+          specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
         }[]
       }
     }
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/active-app-release.ts b/packages/app/src/cli/api/graphql/app-management/generated/active-app-release.ts
@@ -24,7 +24,7 @@ export type ActiveAppReleaseQuery = {
           handle: string
           config: JsonMapType
           target?: string | null
-          specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+          specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
         }[]
       }
     }
@@ -46,7 +46,7 @@ export type AppVersionInfoFragment = {
         handle: string
         config: JsonMapType
         target?: string | null
-        specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+        specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
       }[]
     }
   }
@@ -58,7 +58,7 @@ export type ReleasedAppModuleFragment = {
   handle: string
   config: JsonMapType
   target?: string | null
-  specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+  specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
 }
 
 export const ReleasedAppModuleFragmentDoc = {
@@ -85,6 +85,7 @@ export const ReleasedAppModuleFragmentDoc = {
                 {kind: 'Field', name: {kind: 'Name', value: 'identifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'externalIdentifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'name'}},
+                {kind: 'Field', name: {kind: 'Name', value: 'experience'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'managementExperience'}},
               ],
             },
@@ -186,6 +187,7 @@ export const AppVersionInfoFragmentDoc = {
                 {kind: 'Field', name: {kind: 'Name', value: 'identifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'externalIdentifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'name'}},
+                {kind: 'Field', name: {kind: 'Name', value: 'experience'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'managementExperience'}},
               ],
             },
@@ -254,6 +256,7 @@ export const ActiveAppRelease = {
                 {kind: 'Field', name: {kind: 'Name', value: 'identifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'externalIdentifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'name'}},
+                {kind: 'Field', name: {kind: 'Name', value: 'experience'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'managementExperience'}},
               ],
             },
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/app-version-by-id.ts b/packages/app/src/cli/api/graphql/app-management/generated/app-version-by-id.ts
@@ -18,7 +18,7 @@ export type AppVersionByIdQuery = {
       handle: string
       config: JsonMapType
       target?: string | null
-      specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+      specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
     }[]
   }
 }
@@ -32,7 +32,7 @@ export type VersionInfoFragment = {
     handle: string
     config: JsonMapType
     target?: string | null
-    specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+    specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
   }[]
 }
 
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/app-version-by-tag.ts b/packages/app/src/cli/api/graphql/app-management/generated/app-version-by-tag.ts
@@ -18,7 +18,7 @@ export type AppVersionByTagQuery = {
       handle: string
       config: JsonMapType
       target?: string | null
-      specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+      specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
     }[]
   }
 }
@@ -82,6 +82,7 @@ export const AppVersionByTag = {
                 {kind: 'Field', name: {kind: 'Name', value: 'identifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'externalIdentifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'name'}},
+                {kind: 'Field', name: {kind: 'Name', value: 'experience'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'managementExperience'}},
               ],
             },
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/create-app-version.ts b/packages/app/src/cli/api/graphql/app-management/generated/create-app-version.ts
@@ -20,7 +20,7 @@ export type CreateAppVersionMutation = {
         handle: string
         config: JsonMapType
         target?: string | null
-        specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}
+        specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}
       }[]
       metadata: {versionTag?: string | null; message?: string | null}
     } | null
diff --git a/packages/app/src/cli/api/graphql/app-management/generated/specifications.ts b/packages/app/src/cli/api/graphql/app-management/generated/specifications.ts
@@ -12,6 +12,7 @@ export type FetchSpecificationsQuery = {
     name: string
     identifier: string
     externalIdentifier: string
+    experience: string
     features: string[]
     uidStrategy:
       | {__typename: 'UidStrategiesClientProvided'; appModuleLimit: number; isClientProvided: boolean}
@@ -54,6 +55,7 @@ export const FetchSpecifications = {
                 {kind: 'Field', name: {kind: 'Name', value: 'name'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'identifier'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'externalIdentifier'}},
+                {kind: 'Field', name: {kind: 'Name', value: 'experience'}},
                 {kind: 'Field', name: {kind: 'Name', value: 'features'}},
                 {
                   kind: 'Field',
diff --git a/packages/app/src/cli/api/graphql/app-management/queries/active-app-release.graphql b/packages/app/src/cli/api/graphql/app-management/queries/active-app-release.graphql
@@ -37,6 +37,7 @@ fragment ReleasedAppModule on AppModule {
     identifier
     externalIdentifier
     name
+    experience
     managementExperience
   }
 }
diff --git a/packages/app/src/cli/api/graphql/app-management/queries/specifications.graphql b/packages/app/src/cli/api/graphql/app-management/queries/specifications.graphql
@@ -3,6 +3,7 @@ query fetchSpecifications($organizationId: ID!) {
     name
     identifier
     externalIdentifier
+    experience
     features
     uidStrategy {
       __typename
diff --git a/packages/app/src/cli/models/extensions/extension-instance.ts b/packages/app/src/cli/models/extensions/extension-instance.ts
@@ -2,15 +2,6 @@ import {BaseConfigType, MAX_EXTENSION_HANDLE_LENGTH, MAX_UID_LENGTH} from './sch
 import {FunctionConfigType} from './specifications/function.js'
 import {ExtensionFeature, ExtensionSpecification} from './specification.js'
 import {SingleWebhookSubscriptionType} from './specifications/app_config_webhook_schemas/webhooks_schema.js'
-import {AppHomeSpecIdentifier} from './specifications/app_config_app_home.js'
-import {AppAccessSpecIdentifier} from './specifications/app_config_app_access.js'
-import {AppProxySpecIdentifier} from './specifications/app_config_app_proxy.js'
-import {BrandingSpecIdentifier} from './specifications/app_config_branding.js'
-import {PosSpecIdentifier} from './specifications/app_config_point_of_sale.js'
-import {PrivacyComplianceWebhooksSpecIdentifier} from './specifications/app_config_privacy_compliance_webhooks.js'
-import {WebhooksSpecIdentifier} from './specifications/app_config_webhook.js'
-import {WebhookSubscriptionSpecIdentifier} from './specifications/app_config_webhook_subscription.js'
-import {EventsSpecIdentifier} from './specifications/app_config_events.js'
 import {
   ExtensionBuildOptions,
   buildFunctionExtension,
@@ -34,24 +25,6 @@ import {outputDebug} from '@shopify/cli-kit/node/output'
 import {extractJSImports, extractImportPathsRecursively} from '@shopify/cli-kit/node/import-extractor'
 import {uniq} from '@shopify/cli-kit/common/array'
 
-// DEPRECATED. We should get the experience from the specification instead of hardcoding it based on the identifier.
-// This is a temporary solution to avoid breaking changes while we update the API and the specifications query.
-export const CONFIG_EXTENSION_IDS: string[] = [
-  AppAccessSpecIdentifier,
-  AppHomeSpecIdentifier,
-  AppProxySpecIdentifier,
-  BrandingSpecIdentifier,
-  PosSpecIdentifier,
-  PrivacyComplianceWebhooksSpecIdentifier,
-  WebhookSubscriptionSpecIdentifier,
-  WebhooksSpecIdentifier,
-  EventsSpecIdentifier,
-
-  // Hardcoded identifiers that don't exist locally.
-  'data',
-  'admin',
-]
-
 /**
  * Class that represents an instance of a local extension
  * Before creating this class we've validated that:
diff --git a/packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts b/packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts
@@ -95,6 +95,7 @@ function moduleFromExtension(extension: ExtensionInstance) {
       identifier: extension.specification.identifier,
       externalIdentifier: extension.specification.externalIdentifier,
       name: extension.specification.externalName,
+      experience: extension.specification.experience,
       managementExperience: 'cli',
     },
   }
@@ -1352,6 +1353,14 @@ describe('appExtensionRegistrations', () => {
       registrationId: BrandingSpecIdentifier,
       registrationTitle: 'Config Extension',
       type: 'config_extension',
+      specification: {
+        identifier: BrandingSpecIdentifier,
+        name: 'Config Extension',
+        experience: 'configuration' as const,
+        options: {
+          managementExperience: 'cli' as const,
+        },
+      },
     })
 
     const extensionModule = createMockAppModuleVersion({
@@ -1451,6 +1460,14 @@ describe('appExtensionRegistrations', () => {
         registrationId: id,
         registrationTitle: `Config Extension ${index}`,
         type: 'config_extension',
+        specification: {
+          identifier: id,
+          name: `Config Extension ${index}`,
+          experience: 'configuration' as const,
+          options: {
+            managementExperience: 'cli' as const,
+          },
+        },
       }),
     )
 
@@ -1515,6 +1532,14 @@ describe('appExtensionRegistrations', () => {
           registrationId: id,
           registrationTitle: `Config ${id}`,
           type: 'config',
+          specification: {
+            identifier: id,
+            name: `Config ${id}`,
+            experience: 'configuration' as const,
+            options: {
+              managementExperience: 'cli' as const,
+            },
+          },
         }),
       ),
       // Regular CLI-managed extensions
diff --git a/packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts b/packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts
@@ -82,7 +82,7 @@ import {ListOrganizations} from '../../api/graphql/business-platform-destination
 import {AppHomeSpecIdentifier} from '../../models/extensions/specifications/app_config_app_home.js'
 import {BrandingSpecIdentifier} from '../../models/extensions/specifications/app_config_branding.js'
 import {AppAccessSpecIdentifier} from '../../models/extensions/specifications/app_config_app_access.js'
-import {CONFIG_EXTENSION_IDS} from '../../models/extensions/extension-instance.js'
+
 import {DevSessionCreate, DevSessionCreateMutation} from '../../api/graphql/app-dev/generated/dev-session-create.js'
 import {
   DevSessionUpdate,
@@ -465,7 +465,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
           uidIsClientProvided: spec.uidStrategy.isClientProvided,
           uidStrategy: uidStrategyFromTypename(spec.uidStrategy.__typename),
         },
-        experience: experience(spec.identifier),
+        experience: spec.experience as 'extension' | 'configuration' | 'deprecated',
         validationSchema: spec.validationSchema,
       }),
     )
@@ -603,7 +603,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
             }
           : undefined,
       }
-      if (CONFIG_EXTENSION_IDS.includes(registration.id)) {
+      if (mod.specification?.experience === 'configuration') {
         configurationRegistrations.push(registration)
       } else if (mod.specification?.options?.managementExperience === 'dashboard') {
         dashboardManagedExtensionRegistrations.push(registration)
@@ -693,7 +693,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
         registrationTitle: mod.handle,
         specification: {
           identifier: mod.specification.identifier,
-          experience: experience(mod.specification.identifier),
+          experience: mod.specification.experience as 'extension' | 'configuration' | 'deprecated',
           options: {
             managementExperience: 'cli',
           },
@@ -1358,10 +1358,6 @@ export async function allowedTemplates(
   })
 }
 
-function experience(identifier: string): 'configuration' | 'extension' {
-  return CONFIG_EXTENSION_IDS.includes(identifier) ? 'configuration' : 'extension'
-}
-
 /**
  * Maps the backend uidStrategy __typename to the CLI UidStrategy value.
  * The __typename is always present in the response because the GraphQL document
@@ -1415,7 +1411,7 @@ function appModuleVersion(mod: ReleasedAppModuleFragment): Required<AppModuleVer
       ...mod.specification,
       identifier: mod.specification.identifier,
       options: {managementExperience: mod.specification.managementExperience as 'cli' | 'custom' | 'dashboard'},
-      experience: experience(mod.specification.identifier),
+      experience: mod.specification.experience as 'extension' | 'configuration' | 'deprecated',
     },
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export type ActiveAppReleaseFromApiKeyQuery = {`
`24`	`24`	`handle: string`
`25`	`25`	`config: JsonMapType`
`26`	`26`	`target?: string \| null`
`27`		`- specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}`
	`27`	`+ specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}`
`28`	`28`	`}[]`
`29`	`29`	`}`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export type AppVersionByIdQuery = {`
`18`	`18`	`handle: string`
`19`	`19`	`config: JsonMapType`
`20`	`20`	`target?: string \| null`
`21`		`- specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}`
	`21`	`+ specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}`
`22`	`22`	`}[]`
`23`	`23`	`}`
`24`	`24`	`}`
`@@ -32,7 +32,7 @@ export type VersionInfoFragment = {`
`32`	`32`	`handle: string`
`33`	`33`	`config: JsonMapType`
`34`	`34`	`target?: string \| null`
`35`		`- specification: {identifier: string; externalIdentifier: string; name: string; managementExperience: string}`
	`35`	`+ specification: {identifier: string; externalIdentifier: string; name: string; experience: string; managementExperience: string}`
`36`	`36`	`}[]`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ fragment ReleasedAppModule on AppModule {`
`37`	`37`	`identifier`
`38`	`38`	`externalIdentifier`
`39`	`39`	`name`
	`40`	`+ experience`
`40`	`41`	`managementExperience`
`41`	`42`	`}`
`42`	`43`	`}`