diff --git a/src/config.c b/src/config.c index 6c03cbb476..03c3c271f1 100644 --- a/src/config.c +++ b/src/config.c @@ -444,6 +444,7 @@ void loadServerConfigFromString(char *config) { {"list-max-ziplist-entries", 2, 2}, {"list-max-ziplist-value", 2, 2}, {"lua-replicate-commands", 2, 2}, + {"io-threads-do-reads", 2, 2}, {NULL, 0}, }; char buf[1024]; @@ -3086,7 +3087,6 @@ standardConfig static_configs[] = { /* Bool configs */ createBoolConfig("rdbchecksum", NULL, IMMUTABLE_CONFIG, server.rdb_checksum, 1, NULL, NULL), createBoolConfig("daemonize", NULL, IMMUTABLE_CONFIG, server.daemonize, 0, NULL, NULL), - createBoolConfig("io-threads-do-reads", NULL, DEBUG_CONFIG | IMMUTABLE_CONFIG, server.io_threads_do_reads, 1, NULL, NULL), /* Read + parse from threads */ createBoolConfig("always-show-logo", NULL, IMMUTABLE_CONFIG, server.always_show_logo, 0, NULL, NULL), createBoolConfig("protected-mode", NULL, MODIFIABLE_CONFIG, server.protected_mode, 1, NULL, NULL), createBoolConfig("rdbcompression", NULL, MODIFIABLE_CONFIG, server.rdb_compression, 1, NULL, NULL), diff --git a/src/io_threads.c b/src/io_threads.c index 5b2230f635..b0368cf07b 100644 --- a/src/io_threads.c +++ b/src/io_threads.c @@ -319,7 +319,6 @@ void initIOThreads(void) { int trySendReadToIOThreads(client *c) { if (server.active_io_threads_num <= 1) return C_ERR; - if (!server.io_threads_do_reads) return C_ERR; /* If IO thread is areadty reading, return C_OK to make sure the main thread will not handle it. */ if (c->io_read_state != CLIENT_IDLE) return C_OK; /* Currently, replica/master writes are not offloaded and are processed synchronously. */ diff --git a/src/server.h b/src/server.h index 84a282b6f5..82bfc366f3 100644 --- a/src/server.h +++ b/src/server.h @@ -1744,7 +1744,6 @@ struct valkeyServer { _Atomic uint64_t next_client_id; /* Next client unique ID. Incremental. */ int protected_mode; /* Don't accept external connections. */ int io_threads_num; /* Number of IO threads to use. */ - int io_threads_do_reads; /* Read and parse from IO threads? */ int active_io_threads_num; /* Current number of active IO threads, includes main thread. */ int events_per_io_thread; /* Number of events on the event loop to trigger IO threads activation. */ int prefetch_batch_max_size; /* Maximum number of keys to prefetch in a single batch */ diff --git a/tests/unit/introspection.tcl b/tests/unit/introspection.tcl index 286b02b7d0..352f5f183e 100644 --- a/tests/unit/introspection.tcl +++ b/tests/unit/introspection.tcl @@ -514,7 +514,6 @@ start_server {tags {"introspection"}} { set skip_configs { rdbchecksum daemonize - io-threads-do-reads tcp-backlog always-show-logo syslog-enabled