Feature: Live Refresh on View Orders #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to fix local "TypeError: fsevents is not a constructor". Production apps would eventually update dependencies so this makes sense to do for me.
Has breaking changes, to fix next commit
Because this needs Login state, LoginForm now reports login status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Requires #9 because updated dependencies.
Purpose
Display updates to orders live as they happen. See: Shift3#12
Approach
This extends the view orders fetching mechanism to operate immediately, then every 5s, with a cleanup on
useEffectreturn to cancel the loop when navigating away. The cleanup keeps only one update loop live while navigating around.This only refreshes on the Live Orders screen. Live refresh could instead be on the app layer and delivered through prop drilling. An even cleaner choice would store order info in redux ala Shift3#9, a bonus issue I didn't have time for.
Testing Steps
Make a POST to
live-modewhile observing the View Orders screen.Learning
I knew I needed to manage this update loop on "navigation in" and "navigation out", two explicit events in iOS. I knew
useEffectwas the hook-in point, and the API reference showed me how to cleanup.