Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark menu clicks should push to history #1383

Open
richardxia opened this issue Jul 14, 2024 · 1 comment
Open

Bookmark menu clicks should push to history #1383

richardxia opened this issue Jul 14, 2024 · 1 comment

Comments

@richardxia
Copy link
Member

Currently, the bookmark menu state doesn't affect the browser history, which means that if you hit the back button on your browser, it navigates the page rather than the bookmark menu subpages. In addition, it doesn't even close the bookmark menu, so it's a bit disorienting that the page underneath the menu will change without the menu itself changing.

@richardxia richardxia converted this from a draft issue Jul 14, 2024
@richardxia
Copy link
Member Author

Another related issue to this is that the bookmarks modal will "remember" which subpage it was on, which may be very confusing when you try to reopen the bookmarks modal another way.

For example, suppose you have two bookmark folders: A and B. On the dashboard, if you click A, then it will open up the bookmarks modal to the root, listing both the A and B folders. Then, if you click on A in the modal, it will list the bookmarks with the A folder. If you close the bookmark modal, and then you click on folder B in the dashboard, then it will open up the modal but it will show A's contents, not B's, since it "remembered" the previous page you were at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant