{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":708364387,"defaultBranch":"main","name":"Trail-Sense","ownerLogin":"Shadowstrike-code","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-10-22T10:50:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/148655543?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1697975124.0","currentOid":""},"activityList":{"items":[{"before":"ec994d1826db6c7d7975d97ac387c7a4c10b7f28","after":"de111352073be93283ed43534c80d9456f7a0764","ref":"refs/heads/main","pushedAt":"2023-10-22T11:45:47.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #8 from Shadowstrike-code/Shadowstrike-code-meteorshoweralertcommand-improvement\n\nImprovising MeteorShowerAlertCommand.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955869366\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/8\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/8/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/8\">#8</a> from Shadowstrike-code/Shadowstrike-code-meteor…"}},{"before":null,"after":"a7faed35d7448ced0700790df7421fa959e622f2","ref":"refs/heads/Shadowstrike-code-meteorshoweralertcommand-improvement","pushedAt":"2023-10-22T11:45:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Update MeteorShowerAlertCommand.kt\n\nDescription of the improvement update:\r\n\r\n1. Added comments to improve code readability and explain the purpose of each section of code.\r\n\r\n2. Renamed variables to use more descriptive names, making the code easier to understand.\r\n\r\n3. Used Kotlin's null safety features to handle null values, ensuring that the code is more robust.\r\n\r\n4. Extracted magic numbers and strings into constants for better maintainability.\r\n\r\n5. Extracted the logic for creating the notification into a separate function called createNotification(), improving code organization and reusability.\r\n\r\n6. Extracted the logic for getting the shower description into a separate function called getShowerDescription(), improving code organization and reusability.\r\n\r\nEnding of this commit message: Improved!","shortMessageHtmlLink":"Update MeteorShowerAlertCommand.kt"}},{"before":"7f431960cf81dcd5d91d154de3c0e90f0258a099","after":"ec994d1826db6c7d7975d97ac387c7a4c10b7f28","ref":"refs/heads/main","pushedAt":"2023-10-22T11:42:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #7 from Shadowstrike-code/Shadowstrike-code-lunareclipsealertcommand-improvement\n\nImprovising LunarEclipseAlertCommand.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955868401\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/7\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/7/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/7\">#7</a> from Shadowstrike-code/Shadowstrike-code-lunare…"}},{"before":null,"after":"69412427a91e18338409f00e43d3b4b3fdf77da2","ref":"refs/heads/Shadowstrike-code-lunareclipsealertcommand-improvement","pushedAt":"2023-10-22T11:42:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising LunarEclipseAlertCommand.kt\n\nDescription of the improvement update:\r\n\r\n1. Added comments to improve code readability and explain the purpose of each section of code.\r\n\r\n2. Renamed variables to use more descriptive names, making the code easier to understand.\r\n\r\n3. Used Kotlin's null safety features to handle null values, ensuring that the code is more robust.\r\n\r\n4. Extracted magic numbers and strings into constants for better maintainability.\r\n\r\n5. Extracted the logic for creating the notification into a separate function called createNotification(), improving code organization and reusability.\r\n\r\n6. Extracted the logic for getting the eclipse description into a separate function called getEclipseDescription(), improving code organization and reusability.","shortMessageHtmlLink":"Improvising LunarEclipseAlertCommand.kt"}},{"before":"2ffde7bb485e719eda71e5a657232f5915c508fe","after":"7f431960cf81dcd5d91d154de3c0e90f0258a099","ref":"refs/heads/main","pushedAt":"2023-10-22T11:39:19.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #6 from Shadowstrike-code/Shadowstrike-code-astronomyalertcommand\n\nUpdate AstronomyAlertCommand.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955867465\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/6\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/6/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/6\">#6</a> from Shadowstrike-code/Shadowstrike-code-astron…"}},{"before":null,"after":"6afda9d1726a141cc60c1bc8aeb4ebe23db8d0b4","ref":"refs/heads/Shadowstrike-code-astronomyalertcommand","pushedAt":"2023-10-22T11:39:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Update AstronomyAlertCommand.kt\n\nDescription of the improvement update:\r\n\r\n1. Added comments to improve code readability and explain the purpose of each section of code.\r\n\r\n2. Renamed variables to use more descriptive names, making the code easier to understand.\r\n\r\n3. Used Kotlin's null safety features to handle null values, ensuring that the code is more robust.\r\n\r\n3. Extracted the logic for getting the location into a separate function called getLocation(), improving code organization and reusability.\r\n\r\n4. Extracted the logic for creating the composed command into a separate function called createComposedCommand(), improving code organization and reusability.\r\n\r\n5. Used Kotlin's coroutines to handle asynchronous operations, making the code more efficient and responsive.","shortMessageHtmlLink":"Update AstronomyAlertCommand.kt"}},{"before":"faac7b4848f9b3d3cf296ebcf3c93f5677e18ead","after":"2ffde7bb485e719eda71e5a657232f5915c508fe","ref":"refs/heads/main","pushedAt":"2023-10-22T11:33:16.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #5 from Shadowstrike-code/Shadowstrike-code-SunsetAlarmCommand-improvement\n\nImprovising SunsetAlarmCommand.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955865613\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/5\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/5/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/5\">#5</a> from Shadowstrike-code/Shadowstrike-code-Sunset…"}},{"before":null,"after":"8d24d39b3548cf9db6b70d2af9cbf4dea13ace6c","ref":"refs/heads/Shadowstrike-code-SunsetAlarmCommand-improvement","pushedAt":"2023-10-22T11:32:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising SunsetAlarmCommand.kt\n\nDescription of the improvement update:\r\n\r\n1. Removed unused imports.\r\n\r\n2. Used explicit types for variables.\r\n\r\n3. Used meaningful variable names.\r\n\r\n4. Extracted magic numbers and strings to constants.\r\n\r\n5. Used meaningful function names.\r\n\r\n6. Simplified conditionals using the Elvis operator and early returns.\r\n\r\n7. Extracted common code to separate functions.\r\n\r\n8. Added comments to explain the purpose and functionality of the code.\r\n\r\nEnding of the commit message: I'll improvise more if more is possible to","shortMessageHtmlLink":"Improvising SunsetAlarmCommand.kt"}},{"before":"bbcce55b13dcf1f05af929f908e7b955e93b38a3","after":"faac7b4848f9b3d3cf296ebcf3c93f5677e18ead","ref":"refs/heads/main","pushedAt":"2023-10-22T11:26:49.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #4 from Shadowstrike-code/Shadowstrike-code-astronomypreferences-improvement\n\nImprovising AstronomyPreferences.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955863692\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/4\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/4/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/4\">#4</a> from Shadowstrike-code/Shadowstrike-code-astron…"}},{"before":null,"after":"98099a8ef78ff688f3f7e174b00d0c2a04d8b73a","ref":"refs/heads/Shadowstrike-code-astronomypreferences-improvement","pushedAt":"2023-10-22T11:26:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising AstronomyPreferences.kt\n\nDescription of the improvement update:\r\n\r\n1. Simplified resource access: The `getString()` calls for preference keys have been simplified by using the `toString()` method on the resource IDs directly.\r\n\r\n2. Simplified boolean preference checks: The `showOnCompass` and `showOnCompassWhenDown` properties have been simplified to directly check if the raw value is not equal to \"never\" and if it is equal to \"always\", respectively.\r\n\r\n3. Improved resource usage: The `R.string` resource IDs have been converted to strings using the `toString()` method.","shortMessageHtmlLink":"Improvising AstronomyPreferences.kt"}},{"before":null,"after":"cdfa4a49cb2d07d990ad904ee53268c7b0c0fea4","ref":"refs/heads/Shadowstrike-code-improvement-1","pushedAt":"2023-10-22T11:22:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising AstronomyDailyWorker.kt\n\nDescription of the improvement update:\r\n\r\n1. Lazily initialize `UserPreferences` instance: The `UserPreferences` instance is now lazily initialized using `lazy` delegate, ensuring it is only created when needed.\r\n\r\n2. Move `UNIQUE_ID` to the companion object: The `UNIQUE_ID` constant has been moved to the companion object for better organization.\r\n\r\n3. Simplify function bodies: The `isEnabled` and `getScheduledTime` functions have been simplified by directly returning the preference values.","shortMessageHtmlLink":"Improvising AstronomyDailyWorker.kt"}},{"before":"56cd5b0bd6f5ccc085d4d174af8e97a0bb10af3e","after":"bbcce55b13dcf1f05af929f908e7b955e93b38a3","ref":"refs/heads/main","pushedAt":"2023-10-22T11:19:23.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #3 from Shadowstrike-code/Shadowstrike-code-patch-1\n\nImprovising SunsetAlarmReceiver.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955861569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/3\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/3/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/3\">#3</a> from Shadowstrike-code/Shadowstrike-code-patch-1"}},{"before":null,"after":"b502bbe8dae1f37ada90b60e92af86114de93fd5","ref":"refs/heads/Shadowstrike-code-patch-1","pushedAt":"2023-10-22T11:19:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising SunsetAlarmReceiver.kt\n\nDescription of the improvement update:\r\n\r\n1. Added functionality to enable/disable sunset alerts:  \r\n   - Added a new function `disable()` that disables sunset alerts.\r\n   - Modified the existing `enable()` function to set a flag (`isSunsetAlertEnabled`) indicating that sunset alerts are enabled.\r\n\r\n2. Added functionality to check if sunset alerts are enabled:\r\n   - Added a new function `isSunsetAlertEnabled()` that returns `true` if sunset alerts are enabled based on the preference settings.\r\n\r\n3. Updated the `enable()` function:\r\n   - The `enable()` function now sets the `isSunsetAlertEnabled` flag to `true` when enabling sunset alerts.\r\n\r\n4. Updated the `disable()` function:\r\n   - The `disable()` function sets the `isSunsetAlertEnabled` flag to `false` when disabling sunset alerts.\r\n   - The function also cancels any pending sunset alarms using the `scheduler.cancel()` method.\r\n\r\nEnding of this commit message: Thank you","shortMessageHtmlLink":"Improvising SunsetAlarmReceiver.kt"}},{"before":"d36aa67b0ba17c0567909120259984896ab89682","after":"56cd5b0bd6f5ccc085d4d174af8e97a0bb10af3e","ref":"refs/heads/main","pushedAt":"2023-10-22T11:11:08.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #2 from Shadowstrike-code/Shadowstrike-code-astrochart-improvement\n\nImprovising AstroChart.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955859033\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/2/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/2\">#2</a> from Shadowstrike-code/Shadowstrike-code-astroc…"}},{"before":null,"after":"662a5daeb2e2aba43dda25df5d2f224844cd6041","ref":"refs/heads/Shadowstrike-code-astrochart-improvement","pushedAt":"2023-10-22T11:10:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising AstroChart.kt\n\nDescription of the improvement update:\r\n\r\n1. The chart layers are now declared in a more readable and organized manner.\r\n\r\n2. The `onImageClick` lambda is now passed directly to the `BitmapChartLayer` constructor, simplifying the code.\r\n\r\n3. The `moveSun()` and `moveMoon()` methods now use the elvis operator (`?:`) to simplify null checks and provide more concise code.\r\n\r\n4. The `setMoonImage()` method now unloads the previous moon image if the icon has changed before setting the new image.\r\n\r\n5. The `updateSunArea()` and `updateMoonArea()` methods now use a single return statement and simplify the logic for updating the chart data.\r\n\r\n6. Code formatting and style improvements for better readability.","shortMessageHtmlLink":"Improvising AstroChart.kt"}},{"before":"508dfd4c93316ac4ceb6f90b691978fa06ec53be","after":"d36aa67b0ba17c0567909120259984896ab89682","ref":"refs/heads/main","pushedAt":"2023-10-22T11:05:28.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Merge pull request #1 from Shadowstrike-code/Shadowstrike-code-improvement\n\nImprovising TrailSenseApplication.kt","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1955857224\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Shadowstrike-code/Trail-Sense/issues/1\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Shadowstrike-code/Trail-Sense/pull/1/hovercard\" href=\"https://github.com/Shadowstrike-code/Trail-Sense/pull/1\">#1</a> from Shadowstrike-code/Shadowstrike-code-improv…"}},{"before":null,"after":"8fa85c1532eb026253a4d9d0cf6d4157284daaec","ref":"refs/heads/Shadowstrike-code-improvement","pushedAt":"2023-10-22T11:04:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising TrailSenseApplication.kt\n\nImprovising update description:\r\n\r\n1. Extracted the logic for creating notification channels, migrating preferences, scheduling the repository cleanup worker, starting the weather subsystem, and starting the flashlight subsystem into separate private methods.\r\n\r\nThis improves readability and makes the `onCreate` method more concise.\r\n\r\n2. Added comments to describe the purpose of each extracted method.\r\n\r\n3. Renamed the extracted methods to use more descriptive names.\r\n\r\n4. Updated the method calls to use the new method names.\r\n\r\nConclusion of this improvement update, also include the following: improving organization and readability too.","shortMessageHtmlLink":"Improvising TrailSenseApplication.kt"}},{"before":"508dfd4c93316ac4ceb6f90b691978fa06ec53be","after":"724fe7ae4cd7733664d00451c6cca4151f0a2af6","ref":"refs/heads/patch-1","pushedAt":"2023-10-22T10:55:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Shadowstrike-code","name":"Unknown","path":"/Shadowstrike-code","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/148655543?s=80&v=4"},"commit":{"message":"Improvising WeatherAlertGeneratorTest.kt\n\nImprovising Update:\r\n\r\n1. Added backticks (`) around the test method name (`getAlerts should return the expected alerts`) to allow spaces in the method name.\r\n\r\n2. Updated the test method signature to use backticks around the method name.\r\n\r\n3. Removed the explicit type `emptyList<WeatherAlert>()` and replaced it with `emptyList()` to take advantage of type inference.\r\n\r\nConclusion of this improvement update: Readibility and maintainability.\r\n\r\nEnding of this commit message: Thank you very much for this amazing application to exist","shortMessageHtmlLink":"Improvising WeatherAlertGeneratorTest.kt"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADnORo3wA","startCursor":null,"endCursor":null}},"title":"Activity · Shadowstrike-code/Trail-Sense"}