Added a ping check to commands. This avoids a lot of unnecessary calls if the API key is not set or invalid

Author: loevgaard

src/Client/Client.php

@@ -157,6 +157,11 @@ public function subscribeEmail(AudienceInterface $audience, string $email): void
         );
     }
 
+    public function ping(): void
+    {
+        $this->makeRequest('get', 'ping');
+    }
+
     private function hasOrder(string $storeId, string $orderId): bool
     {
         try {

src/Client/ClientInterface.php

@@ -43,4 +43,9 @@ public function updateMember(AudienceInterface $audience, CustomerInterface $cus
      * @throws ClientException
      */
     public function subscribeEmail(AudienceInterface $audience, string $email): void;
+
+    /**
+     * Will try to ping Mailchimp. If the API key is invalid or something else goes wrong, this will throw an exception
+     */
+    public function ping(): void;
 }

src/Command/LoadAudiencesCommand.php

@@ -4,6 +4,7 @@
 
 namespace Setono\SyliusMailchimpPlugin\Command;
 
+use Setono\SyliusMailchimpPlugin\Client\Client;
 use Setono\SyliusMailchimpPlugin\Loader\AudiencesLoaderInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Command\LockableTrait;
@@ -17,13 +18,17 @@ final class LoadAudiencesCommand extends Command
 
     protected static $defaultName = 'setono:sylius-mailchimp:load-audiences';
 
+    /** @var Client */
+    private $client;
+
     /** @var AudiencesLoaderInterface */
     protected $audiencesLoader;
 
-    public function __construct(AudiencesLoaderInterface $audiencesLoader)
+    public function __construct(Client $client, AudiencesLoaderInterface $audiencesLoader)
     {
         parent::__construct();
 
+        $this->client = $client;
         $this->audiencesLoader = $audiencesLoader;
     }
 
@@ -48,6 +53,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return 0;
         }
 
+        $this->client->ping();
+
         $preserve = (bool) $input->getOption('preserve');
         $this->audiencesLoader->load($preserve);
 

src/Command/PushCustomersCommand.php

@@ -4,6 +4,7 @@
 
 namespace Setono\SyliusMailchimpPlugin\Command;
 
+use Setono\SyliusMailchimpPlugin\Client\Client;
 use Setono\SyliusMailchimpPlugin\Message\Command\PushCustomers;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Command\LockableTrait;
@@ -17,13 +18,17 @@ final class PushCustomersCommand extends Command
 
     protected static $defaultName = 'setono:sylius-mailchimp:push-customers';
 
+    /** @var Client */
+    private $client;
+
     /** @var MessageBusInterface */
     private $commandBus;
 
-    public function __construct(MessageBusInterface $commandBus)
+    public function __construct(Client $client, MessageBusInterface $commandBus)
     {
         parent::__construct();
 
+        $this->client = $client;
         $this->commandBus = $commandBus;
     }
 
@@ -41,6 +46,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return 0;
         }
 
+        $this->client->ping();
+
         $this->commandBus->dispatch(new PushCustomers());
 
         $this->release();

src/Command/PushOrdersCommand.php

@@ -4,6 +4,7 @@
 
 namespace Setono\SyliusMailchimpPlugin\Command;
 
+use Setono\SyliusMailchimpPlugin\Client\Client;
 use Setono\SyliusMailchimpPlugin\Message\Command\PushOrders;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Command\LockableTrait;
@@ -17,13 +18,17 @@ final class PushOrdersCommand extends Command
 
     protected static $defaultName = 'setono:sylius-mailchimp:push-orders';
 
+    /** @var Client */
+    private $client;
+
     /** @var MessageBusInterface */
     private $commandBus;
 
-    public function __construct(MessageBusInterface $commandBus)
+    public function __construct(Client $client, MessageBusInterface $commandBus)
     {
         parent::__construct();
 
+        $this->client = $client;
         $this->commandBus = $commandBus;
     }
 
@@ -42,6 +47,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return 0;
         }
 
+        $this->client->ping();
+
         $this->commandBus->dispatch(new PushOrders());
 
         $this->release();

src/Resources/config/services/command.xml

@@ -7,20 +7,23 @@
 
         <service id="setono_sylius_mailchimp.command.load_audiences"
                  class="Setono\SyliusMailchimpPlugin\Command\LoadAudiencesCommand">
+            <argument type="service" id="setono_sylius_mailchimp.client"/>
             <argument type="service" id="setono_sylius_mailchimp.loader.audiences"/>
 
             <tag name="console.command"/>
         </service>
 
         <service id="setono_sylius_mailchimp.command.push_customers"
                  class="Setono\SyliusMailchimpPlugin\Command\PushCustomersCommand">
+            <argument type="service" id="setono_sylius_mailchimp.client"/>
             <argument type="service" id="setono_sylius_mailchimp.command_bus"/>
 
             <tag name="console.command"/>
         </service>
 
         <service id="setono_sylius_mailchimp.command.push_orders"
                  class="Setono\SyliusMailchimpPlugin\Command\PushOrdersCommand">
+            <argument type="service" id="setono_sylius_mailchimp.client"/>
             <argument type="service" id="setono_sylius_mailchimp.command_bus"/>
 
             <tag name="console.command"/>