Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lofty implement more commonly used vorbis comment fields #511

Open
rudolfkastl opened this issue Mar 17, 2025 · 1 comment
Open

Make lofty implement more commonly used vorbis comment fields #511

rudolfkastl opened this issue Mar 17, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@rudolfkastl
Copy link

Summary

Hello everyone,

It would be great to see lofty support additional commonly used fields for vorbis comments. Specifically i am missing a "tag.set_date".

Please see the list of "commonly used fields" here: https://www.xiph.org/vorbis/doc/v-comment.html

API design

No response

@rudolfkastl rudolfkastl added the enhancement New feature or request label Mar 17, 2025
@Serial-ATA
Copy link
Owner

Hello!

Do you mean add more method on VorbisComments? or on Tag?

For VorbisComments, I'd accept a PR to add a set_date method that takes a Timestamp.

In the case of Tag though, the set_* methods typically come from the Accessor trait. That trait is implemented for all tag types, meaning there should only really be methods for items that can be represented across all tags, so it may not have all the items you're looking for.

In either case, you can always use Tag::insert() or VorbisComments::insert() with a Timestamp string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants