Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor errors in the sample code #820

Closed
imgits opened this issue Jun 28, 2024 · 1 comment · Fixed by #822
Closed

Minor errors in the sample code #820

imgits opened this issue Jun 28, 2024 · 1 comment · Fixed by #822
Labels
bug 🐛 Something isn't working samples 📚 A change or improvement related to the samples

Comments

@imgits
Copy link

imgits commented Jun 28, 2024

The code in file ComputeSharp/samples/ComputeSharp.Benchmark/Blas/BlasHelpers.cs at line 97:

int x_offset = (ThreadIds.X * n * p) + (ThreadIds.Y * m);

Should it be:

int x_offset = (ThreadIds.X * n * m) + (ThreadIds.Y * m);

That is, change 'p' to 'm'
@imgits imgits added bug 🐛 Something isn't working untriaged 🧰 A new issue that needs initial triage labels Jun 28, 2024
@Sergio0694 Sergio0694 added samples 📚 A change or improvement related to the samples and removed untriaged 🧰 A new issue that needs initial triage labels Jul 5, 2024
@Sergio0694 Sergio0694 mentioned this issue Jul 5, 2024
Merged
@Sergio0694
Copy link
Owner

Fixed, thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working samples 📚 A change or improvement related to the samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'x' offset in GPU powered BLAS method Sergio0694/ComputeSharp
2 participants
@imgits @Sergio0694