Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement closeOnChange for removeItemOnBackspace and handleLabelRemove #4491

Open
stevenrick opened this issue Aug 29, 2024 · 1 comment · May be fixed by #4492
Open

Implement closeOnChange for removeItemOnBackspace and handleLabelRemove #4491

stevenrick opened this issue Aug 29, 2024 · 1 comment · May be fixed by #4492

Comments

@stevenrick
Copy link

stevenrick commented Aug 29, 2024 •
edited
Loading

Feature Request

Problem description

I noticed that #1252 implemented an optional prop closeOnChange for Multiple Selection Dropdown that only works when selecting an item to add but does not apply when removing an item.

Proposed solution

Add this.closeOnChange(e) to the end of the following functions: removeItemOnBackspace and handleLabelRemove which are both in src/modules/Dropdown/Dropdown.js

MVP

Proof of concept (showing the problem): https://codesandbox.io/p/sandbox/semantic-ui-react-closeonchange-poc-69t37k
Add items to selection, then remove items via label or backspace while dropdown is focused/open and element will remain open

Forked, Cloned, Installed, and Tested in PR #4492
@welcome Welcome
Copy link

welcome bot commented Aug 29, 2024

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@stevenrick stevenrick linked a pull request Aug 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Dropdown): Adds support for closeOnChange when removing items stevenrick/Semantic-UI-React
1 participant
@stevenrick