Improve parallelization of common subdomains / related block entries

cstigler · cstigler · commit 7d350dab078c · 2021-10-03T16:02:10.000-10:00
diff --git a/Block Management/BlockManager.m b/Block Management/BlockManager.m
@@ -191,12 +191,13 @@ - (void)addBlockEntryFromString:(NSString*)entryString {
     // nil means that we don't have anything valid to block in this entry
     if (entry == nil) return;
 
-    [self addBlockEntry: entry];
-    
+    // enqueue new entries _before_ running this one, so they can happen in parallel
     NSArray<SCBlockEntry*>* relatedEntries = [self relatedBlockEntriesForEntry: entry];
     for (SCBlockEntry* relatedEntry in relatedEntries) {
         [self enqueueBlockEntry: relatedEntry];
     }
+
+    [self addBlockEntry: entry];
 }
 
 - (void)addBlockEntriesFromStrings:(NSArray<NSString*>*)blockList {

Original file line number	Diff line number	Diff line change
`@@ -191,12 +191,13 @@ - (void)addBlockEntryFromString:(NSString*)entryString {`
`191`	`191`	`// nil means that we don't have anything valid to block in this entry`
`192`	`192`	`if (entry == nil) return;`
`193`	`193`
`194`		`- [self addBlockEntry: entry];`
`195`		`-`
	`194`	`+ // enqueue new entries _before_ running this one, so they can happen in parallel`
`196`	`195`	`NSArray<SCBlockEntry> relatedEntries = [self relatedBlockEntriesForEntry: entry];`
`197`	`196`	`for (SCBlockEntry* relatedEntry in relatedEntries) {`
`198`	`197`	`[self enqueueBlockEntry: relatedEntry];`
`199`	`198`	`}`
	`199`	`+`
	`200`	`+ [self addBlockEntry: entry];`
`200`	`201`	`}`
`201`	`202`
`202`	`203`	`- (void)addBlockEntriesFromStrings:(NSArray<NSString>)blockList {`