Skip to content

Commit f291ecd

Browse files
committed
BUGFIX: Keep commandbar centered after it’s opened and not dragged yet
1 parent 4208df1 commit f291ecd

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

Resources/Public/Module.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Resources/Public/Module.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Resources/Public/Plugin.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Resources/Public/Plugin.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/commandbar/src/components/CommandBarDialog/CommandBarDialog.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const CommandBarDialog: React.FC<CommandBarDialogProps> = ({ onDrag, open, toggl
3939
const dialogStyle = useComputed(() => {
4040
const { left, top } = dialogPosition.value;
4141
return (
42-
hasBeenDragged
42+
hasBeenDragged.value
4343
? {
4444
left: left + 'px',
4545
top: top + 'px',
@@ -99,10 +99,10 @@ const CommandBarDialog: React.FC<CommandBarDialogProps> = ({ onDrag, open, toggl
9999

100100
useEffect(() => {
101101
if (!open) return;
102-
dialogRef.current.parentElement.addEventListener('drop', handleDragDrop);
102+
dialogRef.current?.parentElement?.addEventListener('drop', handleDragDrop);
103103
window.addEventListener('resize', onResize);
104104
return () => {
105-
dialogRef.current.parentElement.removeEventListener('drop', handleDragDrop);
105+
dialogRef.current?.parentElement?.removeEventListener('drop', handleDragDrop);
106106
window.removeEventListener('resize', onResize);
107107
};
108108
}, [open, onResize, handleDragDrop]);

0 commit comments

Comments
 (0)