BUGFIX: Setting command as favourite didn’t update it’s state properly

Sebobo · Sebobo · commit 61c0d77d57e0 · 2023-03-15T17:49:39.000+07:00
diff --git a/packages/commandbar/src/state/commandBarReducer.ts b/packages/commandbar/src/state/commandBarReducer.ts
@@ -145,7 +145,7 @@ function runAction(action: ACTION, nextState: CommandBarState, event: CommandBar
         case ACTION.ADD_FAVOURITE:
             assert(event.type === TRANSITION.ADD_FAVOURITE);
             if (!nextState.favouriteCommands.includes(event.commandId)) {
-                nextState.favouriteCommands.push(event.commandId);
+                nextState.favouriteCommands = [...nextState.favouriteCommands, event.commandId];
             }
             break;
         case ACTION.REMOVE_FAVOURITE:

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ function runAction(action: ACTION, nextState: CommandBarState, event: CommandBar`
`145`	`145`	`case ACTION.ADD_FAVOURITE:`
`146`	`146`	`assert(event.type === TRANSITION.ADD_FAVOURITE);`
`147`	`147`	`if (!nextState.favouriteCommands.includes(event.commandId)) {`
`148`		`- nextState.favouriteCommands.push(event.commandId);`
	`148`	`+ nextState.favouriteCommands = [...nextState.favouriteCommands, event.commandId];`
`149`	`149`	`}`
`150`	`150`	`break;`
`151`	`151`	`case ACTION.REMOVE_FAVOURITE:`