-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port time_server.repy
to RepyV2
#7
Comments
Working on this.. |
I have ported this file to repy v2. running this file independently gave getlock() error as below:- and i tried checking restrictions file where getlock is allowed, i think that getlock is a python call, so i imported the file in python and it works. Please find below the ported code. I will work again on this if i am incorrect. https://github.com/asm582/seattleissues/blob/master/time_server.r2py |
If it's ported to RepyV2, then it can't import Python code. For creating a lock in RepyV2, see the API docs. There are other problems with the proposed code too --- you'll see when you fix the lock issue. BTW, any reason you didn't just fork the |
From albert's comments i tried to resolved attribute error exception by using getconnection() and used null check for checking value of object and when found null used exitall() to terminate the program as there is no client to connect. below is the link to modification https://github.com/asm582/timeserver/blob/timeserver_v2/time_server.r2py |
I have tested integration tests for time sever below are the results:- abhishek@abhishek-VirtualBox:~/seattlelib_v2/RUNNABLE$ python test_time_tcp.py abhishek@abhishek-VirtualBox:~/seattlelib_v2/RUNNABLE$ python test_time_servers_running.py I think i have updated the pull request as well with required code and hope to close this ticket soon. |
No description provided.
The text was updated successfully, but these errors were encountered: