Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate StartVessel code from seash_helper. #94

Open
aaaaalbert opened this issue Jun 29, 2015 · 1 comment
Open

Remove duplicate StartVessel code from seash_helper. #94

aaaaalbert opened this issue Jun 29, 2015 · 1 comment
Labels

Comments

@aaaaalbert
Copy link
Contributor

seash_helper.py's function run_target uploads a file to the current target, and then starts it. The function should not duplicate code from start_target, but rather call start_target after uploading.

@aaaaalbert
Copy link
Contributor Author

@Ashmita89, do you have any further questions to my review of your code before you send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant