Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows 7 detection during install #93

Closed
choksi81 opened this issue May 24, 2014 · 1 comment
Closed

Improve Windows 7 detection during install #93

choksi81 opened this issue May 24, 2014 · 1 comment

Comments

@choksi81
Copy link
Contributor

seattleinstaller.py, lines 259 and following, claims to detect Windows 7 using

version = platform.release()
  if version == "Vista" or version == "post2008server":
    # ...

This doesn't always work. As far as I tested on my clean install of Windows 7 Professional (64 bit, German localization), version strings are:

|| '''Python version(s)''' || '''platform.release() string''' ||
|| 2.5.2 and 2.5.4 || Vista ||
|| 2.6.2 to 2.6.5 || post2008Server (note capitalization) ||
|| 2.6.6 and 2.7.0 to 2.7.3 || 7 ||

(See http://bugs.python.org/issue7863 for additional details.)

The lack of "7" and the wrong capitalization of "post2008Server" could be the reason that installing on Windows 7 sometimes fail. So, assuming that the startup behavior of Win7 didn't change over Windows Vista, line 260 of seattleinstaller.py needs to be changed to

if version == "Vista" or version == "post2008Server" or version == "7":

Obviously, the comment block above the statement should be fixed as well. If we were pedantic, the variable version should be renamed release to avoid the perceived name clash with the function platform.version().

Please drop me a line if I can go ahead with patching.

@aaaaalbert
Copy link
Contributor

See also #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants