Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop script does not stop sandboxes... #142

Open
JustinCappos opened this issue Sep 16, 2014 · 3 comments
Open

stop script does not stop sandboxes... #142

JustinCappos opened this issue Sep 16, 2014 · 3 comments

Comments

@JustinCappos
Copy link
Contributor

The stop script and the uninstall script should stop any executing sandboxes. Right now, they continue to execute even after the node manager, etc. stop executing.

We could potentially create stop files to get the vessels to abort...

@JustinCappos
Copy link
Contributor Author

There is a potentially related issue here: SeattleTestbed/softwareupdater#47

@aaaaalbert
Copy link
Contributor

Indeed, the stop script only stops the nodemanager and softwareupdater, but not any sandboxes that might be running. See the Linux stop script for example: https://github.com/SeattleTestbed/dist/blob/new_build_v1/linux/scripts/stop_seattle.sh

The most portable way to stop vessels probably is to use their stopfiles. See the vesseldict key "stopfilename". The functionality should go into https://github.com/SeattleTestbed/dist/blob/new_build_v1/stop_all_seattle_processes.py I think, not the shell/BAT script.

(The potential gotcha is that not all vessels necessarily will have stopfiles. We can only be sure for standard installs.)

@aaaaalbert
Copy link
Contributor

Alternatively, we could add a signal handler to the nodemanager to kill all the processes it spawned earlier when it receives SIGTERM. (This would also fix the softwareupdater issue mentioned above.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants