Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all parts of installation procedure complete successfully #132

Open
choksi81 opened this issue Jun 2, 2014 · 0 comments
Open
Assignees

Comments

@choksi81
Copy link
Contributor

choksi81 commented Jun 2, 2014

When the installers fail to download, our downloadandinstall integration test does not recognize that and proceeds on working on the test, giving us a seemingly unrelated error:

[Jan  3 16:45:04 2014](Fri)Exception: failed to open/read/eval vesseldict file
Error: IOError
Description: [2](Errno) No such file or directory: '/home/integrationtester/seattle/seattle_repy/vesseldict'
Traceback:
  File "/home/integrationtester/cron_tests/downloadandinstallseattle/downloadandinstallseattle.py", line 163, in main
    f=open(prefix + "/seattle/seattle_repy/vesseldict", "r")

Looking at the source file, it is littered with a lot of invocations of common shell utilities. We should change these to be python calls (or do a little more checking) to verify that all the steps in the installation procedure actually succeed.

This is one example of invoking a program without doing error checking:
https://seattle.poly.edu/browser/seattle/trunk/integrationtests/downloadandinstallseattle/downloadandinstallseattle.py#L116

@choksi81 choksi81 self-assigned this Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant