Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments before deployment #2

Closed
aaaaalbert opened this issue Aug 18, 2016 · 3 comments
Closed

Address review comments before deployment #2

aaaaalbert opened this issue Aug 18, 2016 · 3 comments

Comments

@aaaaalbert
Copy link
Contributor

We have a few unaddressed comments for the CI config files in SeattleTestbed/repy_v2#112 . Let's address them so we launch CI!
@aaaaalbert aaaaalbert mentioned this issue Aug 18, 2016
Closed
@lukpueh
Copy link
Collaborator

lukpueh commented Aug 18, 2016

@kellender and @awwad already PR'ed CI configuration files into several SeattleTestbed components. As @aaaaalbert suggests, let's close those PRs, address unaddressed comments here and open new PRs based on the fresh config files.

This was referenced Aug 18, 2016
Closed
Closed
Closed
Closed
@lukpueh
Copy link
Collaborator

lukpueh commented Aug 18, 2016 •
edited
Loading

@awwad: Do we need e1f8673b?

@lukpueh lukpueh mentioned this issue Aug 18, 2016
Closed
@aaaaalbert
Copy link
Contributor Author

This was added test due to SeattleTestbed/seash#99, readline-induced seash unit test errors. We don't have a complete fix for that issue yet.

And yes, @awwad's addition of TERM=... appears to suppress the problem, see the relevant discussion on the issue.

@lukpueh lukpueh mentioned this issue Aug 19, 2016
Merged
@lukpueh lukpueh closed this as completed Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukpueh @aaaaalbert