Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none tags will cause save to fail #609

Closed
khivi opened this issue Aug 7, 2023 · 5 comments
Closed

none tags will cause save to fail #609

khivi opened this issue Aug 7, 2023 · 5 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@khivi
Copy link

khivi commented Aug 7, 2023

Images present before restore step will be skipped; only new images will be saved.
docker save --output ~/.docker-images.tar ghcr.io/foo/node:<none> ghcr.io/foo/node:latest 
Error: Error: Command failed: docker save --output ~/.docker-images.tar ghcr.io/foo/node:<none> ghcr.io/foo/node:latest 
/usr/bin/bash: line 1: none: No such file or directory

@Kurt-von-Laven
Copy link
Contributor

Duplicate #572.

@Kurt-von-Laven Kurt-von-Laven added the duplicate This issue or pull request already exists label Nov 27, 2023
@Kurt-von-Laven Kurt-von-Laven self-assigned this Feb 17, 2024
@Kurt-von-Laven
Copy link
Contributor

@khivi, do you have any thoughts on #789? As a user, I would personally prefer that the action fail rather than filter out anonymous Docker images so that I realize I have forgotten to name and tag some Docker images. I would love input from others on this though since I have never actually used an anonymous Docker image before, and I don't know what purpose they serve.

@khivi
Copy link
Author

khivi commented Mar 8, 2024

I agree that anonymous Docker images are not very useful to save. I do tag our builds. But there is some case where the <none> is getting created in Github actions. I have not been able to figure out why.

To address your concern, maybe we add a 'skip_anonymous' as an option.

@Kurt-von-Laven
Copy link
Contributor

Thank you! It occurs to me that we could probably save the anonymous images by ID and the names ones by name to avoid the need for a feature flag.

@Kurt-von-Laven
Copy link
Contributor

@khivi, I have implemented said strategy adding support for untagged images in #816. I added a test case for an image without a name, but I wonder if you might know how to create an image without a tag using the Docker CLI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Development

No branches or pull requests

2 participants