Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs sidebar only shows translated pages #92

Closed
mxmou opened this issue Jul 21, 2021 · 13 comments
Closed

Docs sidebar only shows translated pages #92

mxmou opened this issue Jul 21, 2021 · 13 comments
Labels
scope: engine Related to the scripts and Hugo stuff of the website type: enhancement New feature or request

Comments

@mxmou
Copy link
Member

mxmou commented Jul 21, 2021

Going to https://scratchaddons.com/sl/docs only shows translates pages in the sidebar.

@Hans5958
Copy link
Member

This is intentional. Really weird to see English pages on other languages.

@mxmou
Copy link
Member Author

mxmou commented Jul 22, 2021

This is intentional. Really weird to see English pages on other languages.

It means that people who set the language to Slovenian and click the documentation link can currently only see the page about adding an icon to a setting name in the sidebar. I know what reading partially translated documentation is like, and I don't think it's as weird as this.

@mxmou
Copy link
Member Author

mxmou commented Feb 26, 2022

Even if this is intentional, it makes the user experience worse and should be changed.

@mxmou mxmou reopened this Feb 26, 2022
@Hans5958
Copy link
Member

I still stand with my opinion. How I look it is that users mostly prefers the absolute source, the English documentation, instead of using secondary sources. With that I don't think people will get bugged that much.

Still, I think it is easy to implement, so I will try to do it. Obviously there will be some parts that will be excluded like policies. I will fill the languages that at least have something translated on the docs (so no unnecessary long language selector)

@Hans5958 Hans5958 added scope: content Related to the contents of the website, excluding blog and docs scope: engine Related to the scripts and Hugo stuff of the website labels Feb 26, 2022
@Hans5958
Copy link
Member

Hans5958 commented Mar 10, 2022

@WorldLanguages Should we do this? Mouse also created #170 for this, so he wants every untranslated page to be up on the website.

@Hans5958
Copy link
Member

Hans5958 commented Mar 10, 2022

cc @apple502j also, I don't know

@WorldLanguages
Copy link
Member

Untranslated strings should be shown in English instead of hiding them

@Hans5958
Copy link
Member

Yes, that will be the case, but should we show these untranslated page, and all of them?

@WorldLanguages
Copy link
Member

@Hans5958 I think so

@Hans5958
Copy link
Member

Hans5958 commented Mar 12, 2022

I have did changes so it will fill untranslated pages with English counterparts. This means that those that are excluded from translation in the first place are not filled. This includes blog, the policies, the references, etc. Let me know if this I also need to do this.

@Hans5958 Hans5958 added type: enhancement New feature or request and removed scope: content Related to the contents of the website, excluding blog and docs labels Mar 12, 2022
@Hans5958
Copy link
Member

Looking back at it now, it seems that it is more-or-less done. I will close this, but please reopen if you got any more objections or such.

@WorldLanguages
Copy link
Member

@Hans5958 Is this actually resolved (if not, please reopen this). I remember these messages from the Discord server by ibailba around a year ago.

image

@Hans5958
Copy link
Member

Nope. It sorta continued on #297. What he's talking is basically already discussed on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: engine Related to the scripts and Hugo stuff of the website type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants