Allow setting dynamic enable/disable behavior per userscript/userstyle

[mxmou]

Is your request related to a problem? Please describe.

dynamicEnable, dynamicDisable, injectAsStyleElt (is that for faster loading? This one might also need a better name) and updateUserstylesOnSettingChange can't have different values for each userscript and userstyle. This is sometimes a problem: for addons that add new UI, it would be helpful to be able to not remove the CSS when it's disabled to prevent flashes when enabling and disabling. It also means that it isn't possible to make an addon that runs on multiple different pages only support dynamic enable/disable on some of them.

Describe the solution you'd like

Make them properties of userscript/userstyle objects, not the addon itself.

[apple502j]

injectAsStyleElt is used by themes that require dynamic modification of style content, AFAIK.

Could be a problem for userscripts: Addon object is per-addon and not per-userscript (this is by design) and so is addon.self, which means state management is a mess.

[cobaltt7]

injectAsStyleElt is also used for addons that need higher specificity then if they were in a file.

[WorldLanguages]

injectAsStyleElt is also used for addons that need higher specificity then if they were in a file.

No. Specificity stays unchanged.
injectAsStyleElt is only for faster loading. Some addons don't need faster loading and still use it, tho.
But realistically, it's built for website dark mode.

[WorldLanguages]

To avoid the flash of content, I think we should first make sure the style loads, then send the reenabled event to the userscript.

It also means that it isn't possible to make an addon that runs on multiple different pages only support dynamic enable/disable on some of them.

Any examples of addons that could make use of that?

[WorldLanguages]

To avoid the flash of content, I think we should first make sure the style loads, then send the reenabled event to the userscript.

This gets a bit more tricky if addon.tab.displayNoneWhileDisabled is used instead of JavaScript, but it still can be done.

[mxmou]

It also means that it isn't possible to make an addon that runs on multiple different pages only support dynamic enable/disable on some of them.

Any examples of addons that could make use of that?

ocular.

[WorldLanguages]

Waiting for response by myself

[scratchaddons-bot]

Ping! There has been no activity for 7 days.

[WorldLanguages]

I think the flashing problem deserves its own "type: bug" issue here

[WorldLanguages]

Note: dynamicDisable never meant anything to userscripts. They get the "disabled" event anyway.

We also need to consider that currently, the settings page does not distinguish between dynamic and non-dynamic addons. We could possibly create a new manifest property that if set to true, reminds the user to refresh after enabling/disabling (and possibly changing any addon settings), that can be arbitrarily set by the addon author, no matter the actual dynamic-ness of the addon.

[WorldLanguages]

injectAsStyleElt (is that for faster loading? This one might also need a better name)

injectAsStyleElt is also used for addons that need higher specificity then if they were in a file.

No. Specificity stays unchanged.

I aim to solve this confusion and properly explain the functioning and purpose of injectAsStyleElt as part of the new userstyle docs: ScratchAddons/website-v2#311

[scratchaddons-bot]

Ping! There has been no activity for 7 days.