Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle over-180-degrees cells without treating edges as latlon-aligned #233

Closed
pp-mo opened this issue Jan 20, 2023 · 2 comments
Closed
Labels
New: Feature Highlight a new community raised "feature request" issue Stale: Closed This stale issue or pull-request has been closed due to no activity Stale: Closure warning This stale issue or pull-request has been marked for closure

Comments

@pp-mo
Copy link
Member

pp-mo commented Jan 20, 2023

Seeing comment here

In addition, ESMF cannot handle any cells covering >=180 degrees, e.g. longitudes -180..+180 : such cases will give errors : These cases can be fixed by specifying resolution=2.

While that statement is all very well, it is in that case simply not doing the same calculation.

So, suppose I have a cell with an edge that runs (-120, -30) to (+120, +30) : I might actually want that line to be on a great circle, and more especially if the boundaries are not generally along lines of latitude or longitude.
I can in principle achieve that by taking a different intermediate point, which lies on the GC instead of the 'straight latlon' line.
But obviously, this is not what the resolution keyword provides.

In fact, this could occur any time a target may have cells which are "large" but not specially latlon-aligned, and it particular when their edges are supposed to be on GCs rather than some 'straight latlon' line.

In effect, this is due to the conflation of the "two problems" I mentioned in the above comment : that of handing overlarge cells, and of approximating 'straight latlon' boundary lines.

So "ideally", we could provide an additional keyword that controls whether the boundaries of over-large cells are divided along a latlon line, or on a GC.
E.G. a new key likeresolve_latlon=True, for both GridToMeshESMFRegridder and MeshToGridESMFRegridder

@pp-mo pp-mo added the New: Feature Highlight a new community raised "feature request" issue label Jan 20, 2023
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Apr 21, 2023
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This stale issue has been automatically closed due to no community activity

@github-actions github-actions bot added the Stale: Closed This stale issue or pull-request has been closed due to no activity label Apr 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New: Feature Highlight a new community raised "feature request" issue Stale: Closed This stale issue or pull-request has been closed due to no activity Stale: Closure warning This stale issue or pull-request has been marked for closure
Projects
None yet
Development

No branches or pull requests

1 participant