Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes to utils and calibration #118

Open
tdowrick opened this issue May 30, 2022 · 1 comment
Open

Breaking changes to utils and calibration #118

tdowrick opened this issue May 30, 2022 · 1 comment

Comments

@tdowrick
Copy link
Collaborator

Hi both,

There’s some breaking changes coming to scikit-surgeryutils.

OpenCV-Headless

Due to changing to opencv-headless, this means that scikit-surgeryimage, vtk, calibration etc. cannot have opencv GUIs in them. So, the video calibration apps had to move out of scikit-surgerycalibration into scikit-surgeryutils. 

Libraries that are now on opencv-headless.

scikit-surgeryimage>=0.10.1
scikit-surgeryvtk>=1.0.6
scikit-surgerycalibration>=0.2.1

(which was enough for SmartLiver incidentally)

scikit-surgeryarucotracker>=0.2.7

and I’m doing scikit-surgeryutils

Further along, this means that scikit-surgerybard will need doing before the summer school in July, and should call utilities in scikit-surgeryutils. Same argument probably for MPHY0026 in due course.

Widget API changes

Also, in scikit-surgeryutils, this meant that I had to use PySide2 for the video calibration apps, and some refactoring. The OverlayBaseApp should really be a widget, so that it can be embedded in layouts. So, I made it a widget. This means the update() method, called by the QTimer had to change to update_view(). 

So, these will have knock on effects to snappysonix, and various demo apps and tutorials. 

Now, as it happened, I made these widget changes, while trying to address the first issue, but ended up making a separate widget for the video apps. So, I could roll them back. But I don’t think its worth it, as we should move forward.

Any thoughts? Or anything I’ve forgotten?

M

@thompson318
Copy link
Collaborator

Thanks, looks generally OK with me. It would be worth sitting down and working out which of the command line apps that were originally in BARD we actually use for teaching. I think some of them are bit obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants