Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vendor extensions #15

Open
egoodhall opened this issue Jul 27, 2018 · 2 comments
Open

Add support for vendor extensions #15

egoodhall opened this issue Jul 27, 2018 · 2 comments

Comments

@egoodhall
Copy link
Contributor

egoodhall commented Jul 27, 2018

Thank you for everything you've done on this library, it's awesome. I'm currently using it in a project uses vendor extensions, and while it seems that vendor extensions aren't currently supported by swagger-diff, I currently have a local implementation that supports vendor extensions in all of the Swagger 2.0 supported locations.

It's a sizable change, due to the fact that vendor extensions can be found in so many places throughout swagger specifications, and the rendering has to be modified as well to fit this. If you think there's a better way to do this, or have strong opinions on whether/how it should be exposed, I'd love any suggestions.

@Sayi
Copy link
Owner

Sayi commented Jul 28, 2018

I have not used vendor extensions, you will do better than me.

@egoodhall
Copy link
Contributor Author

Hi again, I've made a pull request that adds support for vendor extension diffing. It doesn't make any breaking changes to the API, so it shouldn't break any existing code. It does add overloaded compareV1 and compareV2 methods, with an additional boolean argument withExtensions that will enable vendor extension diffing if set to true. I'd appreciate if you could take a look at it when you get the chance, and let me know if there's anything I can do to help get it merged/deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants