Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nora v3.1.0-stable Minor Update #258

Open
wants to merge 112 commits into
base: master
Choose a base branch
from
Open

Nora v3.1.0-stable Minor Update #258

wants to merge 112 commits into from

Conversation

Sandakan
Copy link
Owner

@Sandakan Sandakan commented Jun 2, 2024 •
edited
Loading

Nora v3.1.0-stable Minor Update

Description:

Changelog:

  • 🎉 New Features and Updates

  • 🔨 Fixes and Improvements

    • Nora was fully converted to an ESM-packaged app.
    • Fixed a bug where the correct lyrics line won't scroll to the center of the screen if the song is paused.
    • Fixed a bug where items in ArtistPage, AlbumPage, PlaylistPage, and GenrePage are not centered in their grid cells.
    • Updated the build workflow to fix a bug for the Nora app that is missing sharp dependencies in Linux environments.
    • Fixed some localization errors in the en.json file.
    • Fixed a bug where Discord Presence doesn't update as the player state changes. Fixes Discord RPC does not pause on Nora pause #244.
    • Fixed a bug where the sidebar shows a dynamic theme color in dark mode even though dynamic themes are disabled.
    • Fixed a bug where some views show light mode even though the dark mode is selected.
    • Fixed some localization issues.
    • Fixed a bug where some buttons in the About section of the Settings page are misaligned.
    • Fixed a bug where non-library songs were not showing in Last.FM.
    • Fixed localization issue in LyricsPage title, not allowing changing lyrics offline/online status.
    • Fixed a bug where lyric metadata are lost when saving lyrics from lrclib to lrc files.
    • Fixed a bug where the first metadata line in LRC lyrics is considered a lyric line.
    • Fixed a bug where the app starts with the white splash even though the app is in dark mode. Fixes Use configured theme for splash screen #272.
    • Updated hyperlinks always to be underlined.
    • Fixed lyrics that were not updated on LyricsPage right after modifying them in LyricsEditingPage.
    • Fixed lyrics lines in LyricsEditingPage don't follow dynamic theme colors.
    • Fixed app name showing "Elctron" instead of Nora. Fixes Bug: Window title is "Electron" #288.
    • Removed full-screen player that starts with lyrics showing.
    • Updated discord-rich-presence to display the current song position. Thanks @ElectroHeavenVN.

  • 🐜 Known Issues and Bugs

Other Issues:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally before submission with npm lint and npm run prettier-write commands?
  • Have you successfully run the app with your changes locally with npm run dev?

Important

Fill the checklist items below to,

  • release a new update of the app
  • add an emergency change

Pull requests that directly modify the main branch should only fill the checklist items. > Delete if it's not the case.

  • Create a version artwork (if the update is minor or major).
  • Create and paste the artwork for the installer to the /build/installer_assets/sidebar.bmp directory.
  • Update the version entry in the package.json and package-lock.json files in the root directory.
  • Manage the changelog of this release
    • Copy the release notes from this PR and paste them to the changelog.md file.
    • Create a new versions entry in release-notes.json file.
      • Add the artworkPath to the entry.
      • Add relevant importantNotes to the entry.
      • Copy each release note, remove unnecessary items like markdown syntax, and add them to the new, fixed, and knownIssues sections separately in the notes entry.
      • Update these changes in that file's latestVersion entry.
      • Verify the file with the release-notes-schema.json file.
  • Update the readme.md file of the project
    • Update the release downloads badge URL with the created tag (same as the version entry in package.json) of the release.

@Sandakan
Updated to v3.1.0-stable.20240602
fd2d137 
- Updated the build workflow to fix a bug for Nora app missing sharp dependencies in Linux environments.
- Added experimental playback support for m4a and opus songs. Fixes #247, #242.
- Fully converted Nora to an ESM package.
- Added support for fetching lyrics from LRCLIB. Fixes #252.
- Fixed a bug where the correct lyrics line won't scroll to the center of the screen if the song is paused.
- Fixed a bug where items in ArtistPage, AlbumPage, PlaylistPage, GenrePage are not centered in their grid cells.
@Sandakan Sandakan added the 🎉 enhancement New feature or request label Jun 2, 2024
@Sandakan Sandakan self-assigned this Jun 2, 2024
@Sandakan Sandakan linked an issue Jun 2, 2024 that may be closed by this pull request
OPUS Support (Feature Request for Nora) #242
Closed
Brunight and others added 6 commits June 3, 2024 19:37
@Brunight
add support for symbolic links
1a8ca83
@Brunight
fix misstype
3b9a878
@Brunight
add try catch block so the function doesn't throw with broken symlinks
6bc7e74
@Sandakan
Updated to v3.1.0-stable.20240607
76a4574 
- Added support for reading LRC files without the relevant song extension.
- Discord Presence now updates as the player state changes.
- Refactored front-end codebase use destructured imports to improve build size and performance.
- Refactored all prompt menus to lazy load to improve performance.
- Fixed some localization errors in en.json file.
@Sandakan
Merge pull request #259 from Brunight/minor-release
ec922e2 
Add support for symbolic links
@Sandakan
Updated to v3.1.0-stable.20240615
3747e95 
- Configured to build Nora in rpm and flatpak packages.
- Moved player related logic such as audio fade in/out to a new file.
- Fixed a bug where sidebar shows a dynamic theme color in dark mode even though dynamic themes are disabled.
- Fixed a bug where some views show light mode even though the dark mode is selected.
- Fixed some localization issues.
- Added support for copying lyrics lines.
- Fixed a bug where some buttons in the About section of the Settings page are misaligned.
@Sandakan Sandakan linked an issue Jun 15, 2024 that may be closed by this pull request
Publish on Flatpak #262
Closed
@Sandakan Sandakan removed a link to an issue Jun 15, 2024
Publish on Flatpak #262
Closed
Sandakan and others added 17 commits June 17, 2024 18:42
@Sandakan
Updated to v3.1.0-stable.20240617
76c6d30 
- Temperarily added macos support.
- Fixed some localization errors.
@Sandakan
Merge branch 'master' into minor-release
8dcb05a
@Sandakan
Fixed Nora not importing/exporting theme data
ce631e5
@Sandakan
Merge branch 'minor-release' of https://github.com/Sandakan/Nora into…
8fe8b8e 
… minor-release
@Sandakan
Added file associations .icns files
d191db0
@Sandakan
Fixed incorrect file associations .icns paths
c2d2a1c
@Sandakan
Fixed incorrect file associations .icns paths
c8fb97b
@Sandakan
Fixed non-library songs not showing in Last.FM
6fa818f
@Sandakan
Enabled test and lint workflows
7cd905d
@Sandakan
Added a blurred background to full and mini player
e77aa3b 
- Updated app dependencies.
- Disabled prettier lint workflow because it doesn't detect the config file.
- Added a `how to use` prompt when visiting the lyrics editor for the first time.
@Sandakan
Added new shortcut to open the shortcuts prompt
9dec16a
@ElectroHeavenVN
Create vi.json
3910674
@ElectroHeavenVN
Update i18n.ts
a9a1629 
Add Vietnamese as the 3rd option
@ElectroHeavenVN
Run npm run prettier-write
886c279
@Sandakan
added skip lyrics lines functionality to mini and full screen player
f795e72
@Sandakan
Added volume control to full-screen player.
b6258b0 
- Fixed localization issue in LyricsPage title not allowing to change lyrics offline/online status.
@ElectroHeavenVN
Merge remote-tracking branch 'upstream/minor-release' into minor-release
808acbf
Sandakan and others added 30 commits November 8, 2024 01:20
@Sandakan
Fixed event listeners not being detached correctly
d6575a2 
- Improved preloader component performance.
- Updated app dependencies.
@ElectroHeavenVN
Merge remote-tracking branch 'upstream/minor-release' into new-features
2919cc4
@ElectroHeavenVN
Update romanized lyrics
2dca1de
@ElectroHeavenVN
Refactor
79346d6
@Sandakan
Updated app dependencies.
a5fce0c 
- Fixed app name showing "Elctron" instead of Nora.
- Removed full-screen player starts with lyrics showing.
@Sandakan
Fixed incompatible peer deps
f5f5229
@Sandakan
Merge pull request #282 from ElectroHeavenVN/new-features
2accfef 
Add lyrics conversion and other fixes
@Sandakan
Fixed outdated lock file error and lyrics pinyin import error
6b26b0a
@ElectroHeavenVN
Update parseLyrics.test.ts
21de522
@ElectroHeavenVN
change pinyin library to pinyin-pro
88f7b17
@ElectroHeavenVN
refactor
c252304
@ElectroHeavenVN
fix non-Chinese characters in lyrics
f2c5a37
@ElectroHeavenVN
Update romanizeLyrics.ts
189c767
@Sandakan
Merge pull request #292 from ElectroHeavenVN/new-features
144f4db 
Update Pinyin library and small adjustments
@Sandakan
Added possible fix for missing sharp dependency in linux
b112e60
@Sandakan
Fixed incorrect command lint command listed in pull_request_template
51d13e0
@ElectroHeavenVN
Change Kuroshiro library, fix errors and warnings in the `npm run lin…
627e73d 
…t` command
@ElectroHeavenVN
Update LyricsPage.tsx
24e4459
@Sandakan
Merge pull request #293 from ElectroHeavenVN/new-features
c9c4dac 
Update Pinyin library and small adjustments [2]
@Sandakan
Added electron-builder asarUnpack entry possibly fix sharp error in l…
25424c8 
…inux
@Sandakan
Fixed media session metadata not showing
dbbe941
@Sandakan
added relevant configs
4b5d69d
@Sandakan
Added possible fix for peer deps conflict when using eslint-v9
b270097
@Sandakan
completed eslint migration to v9
b9b9e20
@Sandakan
Merge pull request #297 from Sandakan/eslint-v9
0325c0f 
Eslint v9 update
@Sandakan
disabled eslint linting in ci/cd workflow temperorily
318fc2c
@Sandakan
updated deps
0fc4102
@Sandakan
Updated deps
2cf2cba
@Sandakan
Updated tsconfig to target ES2022 and moduleResolution to bundler
ba0c246
@Sandakan
Merge pull request #298 from Sandakan/tsconfig-nodenext
7ed644e 
Updated tsconfig to target ES2022 and moduleResolution to bundler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sandakan Sandakan

Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Sandakan @Brunight @ElectroHeavenVN