Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature Request for Nora) FLAC support #142

Closed
LatroM69 opened this issue Mar 18, 2023 · 5 comments · Fixed by #152
Closed

(Feature Request for Nora) FLAC support #142

LatroM69 opened this issue Mar 18, 2023 · 5 comments · Fixed by #152
Assignees
@Sandakan
Labels
🎉 enhancement New feature or request

Comments

@LatroM69
Copy link

I think think the player is really good, design wise. But the problem is, this doesn't support FLAC files. Would be great if it is possible to add support for FLAC.
@LatroM69 LatroM69 added the 🎉 enhancement New feature or request label Mar 18, 2023
@LatroM69 LatroM69 changed the title Feature Request for Nora (Feature Request for Nora) FLAC support Mar 18, 2023
@Sandakan
Copy link
Owner

I can provide support for FLAC files in Nora.
But some features like metadata editing doesn't support the FLAC extension.

I'll try something about this.

@LatroM69
Copy link
Author

I can provide support for FLAC files in Nora. But some features like metadata editing doesn't support the FLAC extension.

I'll try something about this.

Good to hear, take your time!
Cheers.

@LatroM69 LatroM69 reopened this Mar 18, 2023
@Sandakan
Copy link
Owner

I can provide support for FLAC files in Nora. But some features like metadata editing doesn't support the FLAC extension.
I'll try something about this.

Good to hear, take your time! Cheers.

But I won't be able to provide support for editing songs in FLAC format until the dependency that I use for editing song tags supports it.

Sandakan added a commit that referenced this issue Mar 25, 2023
@Sandakan
Updated to v2.0.0-stable.20230325
d8481b0 
- Added playback only experimental support for audio formats like FLAC, AAC and M4R. Fixes #148 and #142.
- Added support for viewing storage usage by the app.
- Improved directory handling by the app.
- Removed some unnecessary webpack config options.
- Added contributing.md and pull_request_template.
- Reduces the brightness of background artworks.
- Improved the readme.md.
- Moved some unnecessary  userData properties from the main process  to the render process localStorage.
- Added experimental support for an improved folder structure.
- Added experimental support for suggestions for duplicate artists and artists identified as single artists.
- Fixed a bug where error messages and stack traces aren't being added to the log file.
- Fixed a bug where updating song id3 tags doesn't update album metadata.
- Fixed a bug where app doesn't check for updates right after the connection was established.
- Fixed a bug where focus state of a button persists even after the button is clicked.
- Fixed a bug where SongTagsEditingPage allows to check for song online results even though the app isn't connected to the internet.
-  Fixed a bug where diabled buttons show a loading animation. Fixes #139.
- Fixed a bug where clicking the recent search results and clicking another element to go to another page and come back doesn't persist the clicked recent search result in the search page.
- Added a new context option for the currently playing song artwork to the currently playing song's album. Fixes #149,
- Improved accessibility in SongTagsEditingPage.
- Added a new banner to the SongTagsEditingPage when trying to edit song formats that are only supported for playback only.
- Fixed a bug where hovering over seek bars show an incorrect value.
- Fixed a bug where the message 'No Synced Lyrics Found' persists after disabling the lyrics.
@Sandakan Sandakan mentioned this issue Mar 27, 2023
Merged
@Sandakan Sandakan linked a pull request Mar 29, 2023 that will close this issue
Nora v2.0.0-stable major update #152
Merged
@Sandakan Sandakan pinned this issue Apr 12, 2023
@JustCallMeQuincy
Copy link
Contributor

Confirmed!

@cuhsy
Copy link

cuhsy commented Feb 22, 2024

Support for editing flac files would be really useful. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sandakan Sandakan

Labels
🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nora v2.0.0-stable major update Sandakan/Nora
4 participants
@Sandakan @JustCallMeQuincy @cuhsy @LatroM69