Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear and inconsistent function used in test_flight_interventions.jl #11

Open
TheHelenofTroy opened this issue May 15, 2020 · 0 comments

Comments

@TheHelenofTroy
Copy link

TheHelenofTroy commented May 15, 2020

In tests/test_flight_interventions.jl, the function model_ingredients_from_data is called multiple times, but none of which matches any of the two functions named model_ingredients_from_data in src/transmissionmodel.jl on https://github.com/SamuelBrand1/KenyaCoV/blob/master/src/transmissionmodel.jl#L66 and https://github.com/SamuelBrand1/KenyaCoV/blob/master/src/transmissionmodel.jl#L101.

The function in the test script has a float type argument, and neither function in the source specifies a float type argument. Based on naming convention, both functions with the same name model_ingredients_from_data are calling for string type arguments.

Julia throws MethodError and LoadError for this test script when the function is called.

@TheHelenofTroy TheHelenofTroy changed the title Inconsistent function use in test scripts Inconsistent function use in test_flight_interventions.jl May 15, 2020
@TheHelenofTroy TheHelenofTroy changed the title Inconsistent function use in test_flight_interventions.jl Unclear and inconsistent function used in test_flight_interventions.jl May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant