Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression with Blendmode introduction #545

Open
christoph-hart opened this issue Jul 15, 2023 · 5 comments
Open

Performance regression with Blendmode introduction #545

christoph-hart opened this issue Jul 15, 2023 · 5 comments
Assignees

Comments

@christoph-hart
Copy link

It appears that the commit that introduces the AfterEffects blend mode simulation vastly decreases the performance of the renderer.

1916436

@JSUYA
Copy link
Collaborator

JSUYA commented Jul 20, 2023

Hi @mihashco @JoogabYun Can you review this issue and performance check?
1916436#commitcomment-121705281

@JoogabYun
Copy link
Collaborator

Yes we are taking this seriously. We are trying to improve.

@smohantty
Copy link
Contributor

I think the patch makes every layer rendering goes through intermediate buffer instead of only layers which needs this ( has blending mode ) . I think it will be better to revert this patch and put one slow path only for the particular usecase.

@JoogabYun
Copy link
Collaborator

Fixed with this patch.
#546

@KonstantinRitt
Copy link

KonstantinRitt commented Jun 20, 2024

fixed by f969abf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants