Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy: ESC bypass prevention causes multiple resource pack loads #57

Open
SamB440 opened this issue Feb 10, 2024 · 0 comments
Open

Legacy: ESC bypass prevention causes multiple resource pack loads #57

SamB440 opened this issue Feb 10, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@SamB440
Copy link
Owner

SamB440 commented Feb 10, 2024

We are currently resending the resource pack to open the prompt screen constantly.

But if the player accepts, they could then receive another resource pack packet, which will cause it to load twice, or even worse fail download as it's sent whilst the player is already loading a resource pack.

I thought this was working fine for the past few years. I'm not sure why it doesn't work now - we do use packets instead of API methods, but esc out doesn't tell the server when it does so, and I don't think Spigot would be doing anything anyway, so this must have always been a bug.

I don't know how to fix this. I do wonder how FRP (https://www.spigotmc.org/resources/force-resourcepacks.10499/) handles this.

@SamB440 SamB440 added bug Something isn't working help wanted Extra attention is needed labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant