Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity translations #14

Open
SamB440 opened this issue Dec 27, 2022 · 3 comments
Open

Velocity translations #14

SamB440 opened this issue Dec 27, 2022 · 3 comments
Labels
enhancement New feature or request velocity Specifically related to Velocity proxies

Comments

@SamB440
Copy link
Owner

SamB440 commented Dec 27, 2022

As per the discussion on #13, translations for velocity need to be added somehow.

Best idea is probably to have a language file with translation keys such as servers.example-server.resourcepack.prompt="<yellow>Please accept our resource pack to improve your experience.".

@SamB440 SamB440 added the enhancement New feature or request label Dec 27, 2022
@SamB440 SamB440 added the velocity Specifically related to Velocity proxies label Jul 26, 2023
@Cryptite
Copy link

Cryptite commented Jan 4, 2024

Maybe known, but I can't figure out how, or if there's a way to use the lang files for the translation of resourcepack.prompt. If you delete it, it errors. Unsure why it doesn't use prompt_text in the lang files, or whether this is a [global-pack] problem only?

It's the most useful one to translate too!

@SamB440
Copy link
Owner Author

SamB440 commented Jan 4, 2024

I don't have translations set up for velocity yet. From what I can tell the adventure API only allows using an internal resource bundle of translations, rather than having configurable files... doesn't help that they have 0 documentation on this.

@SamB440
Copy link
Owner Author

SamB440 commented Feb 3, 2024

https://stackoverflow.com/questions/1172424/how-to-load-a-resource-bundle-from-a-file-resource-in-java

Seems this will work for loading translations from file.

But I'm currently waiting for velocity to fix their resource pack API, since there are several bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request velocity Specifically related to Velocity proxies
Projects
None yet
Development

No branches or pull requests

2 participants