Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

団体応募の際自身をgroup_memberとして追加できないようにする #235

Open
Cj-bc opened this issue Sep 16, 2018 · 0 comments
Open

団体応募の際自身をgroup_memberとして追加できないようにする #235

Cj-bc opened this issue Sep 16, 2018 · 0 comments
Labels
after first release to do after the first release good first issue Good for newcomers low priority This issue or pull request can be postponed refactoring Changes not in its behavior, but in the code

Comments

@Cj-bc
Copy link
Member

Cj-bc commented Sep 16, 2018 •
edited
Loading

Step 2: 問題

どうなってしまうか:

  • applyにて、自分自身をgroup_membersに含めた場合が考慮されておらずエラーが発生する可能性がある
  • 現状frontendで対応できている模様、但しのちに直した方がいい

どうなるべきだったのか:

  • DBアクセスする前に、エラーで返すべきかと

関連するコード:

// TODO(you): code here to reproduce the problem
@Cj-bc Cj-bc added low priority This issue or pull request can be postponed refactoring Changes not in its behavior, but in the code after first release to do after the first release labels Sep 16, 2018
@Cj-bc Cj-bc changed the title 団体応募の際自身を 団体応募の際自身をgroup_memberとして追加できないようにする Sep 17, 2018
@shino16 shino16 added the investigation required Further investigation is requested label Sep 17, 2018
@shino16 shino16 added the good first issue Good for newcomers label Mar 25, 2019
@shino16 shino16 removed the investigation required Further investigation is requested label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
after first release to do after the first release good first issue Good for newcomers low priority This issue or pull request can be postponed refactoring Changes not in its behavior, but in the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cj-bc @shino16