Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No args typing #28

Open
MelonCola opened this issue May 4, 2022 · 1 comment
Open

No args typing #28

MelonCola opened this issue May 4, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MelonCola
Copy link

Unlike EE3, the generic for the EventEmitter type here only seems to take event names, and not the argument types, allowing for potential errors in a TypeScript setting.
Is there any reason for that I'm missing?

@SachsKaylee
Copy link
Member

Such a feature was planned back in the days, but since we currently do not have an active project that uses this library we never got around to implement it (there are still some code remnants from the base library we originally based this one on actually). If we find the time to return to this library again in the future its the number one priority.

If you want to take a shot at it, we're always happy to accept PRs too! :)

@SachsKaylee SachsKaylee added enhancement New feature or request help wanted Extra attention is needed labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants