Skip to content

Commit 6a214e4

Browse files
committed
Fix Dispose()
1 parent 9cc26ef commit 6a214e4

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

SagiriApp/Models/SagiriModel.cs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal class SagiriModel : BindableBase, IDisposable
3434
private ISpotifyService _ISpotifyService { get; init; } = new SpotifyService();
3535
private IMisskeyService _IMisskeyService { get; init; } = new MisskeyService();
3636

37-
private Logger _Logger { get; init; } = Logger.GetInstance;
37+
private Logger _Logger { get; set; } = Logger.GetInstance;
3838

3939
private static Lazy<HttpClient> _Client { get; set; } = new();
4040
private CancellationTokenSource _CancellationSource { get; init; } = new();
@@ -65,9 +65,16 @@ internal SagiriModel() { }
6565

6666
public void Dispose()
6767
{
68+
_ISpotifyService?.Dispose();
69+
_IMisskeyService?.Dispose();
70+
6871
CurrentTrackInfo.AddTo(_cd);
6972
IsSpotifyPlaying.AddTo(_cd);
73+
PostingFormat.AddTo(_cd);
7074
_cd.Dispose();
75+
76+
_CancellationSource?.Dispose();
77+
_Logger = null;
7178
}
7279

7380
#endregion Public Methods
@@ -258,7 +265,7 @@ private void _OnSpotifyCurrentTrackErrorDetected()
258265
MessageBox.Show("Spotify CurrentTrackError...", "Sagiri-NowPlaying Closed...");
259266
_Logger.WriteLog("Spotify CurrentTrackError...", Logger.LogLevel.Error);
260267

261-
_ISpotifyService.Dispose();
268+
_ISpotifyService?.Dispose();
262269
}
263270

264271
private void _NotifyErrorCredentialInfo(string errorType, string title, string message = "")

SagiriApp/ViewModel/SagiriViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ internal SagiriViewModel()
4949

5050
NowPlayingCommand = new AsyncReactiveCommand().WithSubscribe(async () => await _SagiriModel.PostMisskeyAsync()).AddTo(_cd);
5151
AlbumArtClickCommand.Subscribe(_ => SagiriModel.ViewAlbumArt()).AddTo(_cd);
52-
SettingJsonSaveCommand.Subscribe(_ => _SagiriModel.SaveSetting());
52+
SettingJsonSaveCommand.Subscribe(_ => _SagiriModel.SaveSetting()).AddTo(_cd);
5353
}
5454

5555
public void Dispose() => _cd.Dispose();

0 commit comments

Comments
 (0)