Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host networking is not applied to the container #174

Closed
lvenier opened this issue Jan 14, 2025 · 1 comment
Closed

Host networking is not applied to the container #174

lvenier opened this issue Jan 14, 2025 · 1 comment
Assignees

Comments

@lvenier
Copy link
Contributor

lvenier commented Jan 14, 2025

Based on the issue SaaShup/netbox-docker-plugin#179 the NetworkMode is not properly added during the container recreation.

To change the behavior we would need to set :

  • default NetworkMode to "bridge".
  • NetworkMode to "host" if the network attached is a host type.
    It must also be checked for all attached networks (in the connect phase of the recreation)

NetworkMode "none" should be handled to specific value no handled in this issue.

Opinions welcome.

@fanshan
Copy link
Contributor

fanshan commented Jan 15, 2025

Closed by #175

@fanshan fanshan closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants