Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running drivegroup based osd deployment post-upgrade #1625

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

jschmid1
Copy link
Contributor

@jschmid1 jschmid1 commented Apr 24, 2019

In a post-upgrade scenario the user still has old-style profiles defined in the
pillar.

Since we don't force the user to move to the new drive-group implementation
right after the upgrade, we have to detect that they are running in 'legacy'
mode and stop.

Fixes #

Description:


Checklist:

  • Added unittests and or functional tests
  • Adapted documentation
  • Referenced issues or internal bugtracker
  • Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

@jschmid1 jschmid1 requested review from jan--f and tserong April 24, 2019 12:39
@jschmid1
Copy link
Contributor Author

@susebot run teuthology

@susebot
Copy link
Collaborator

susebot commented Apr 24, 2019

Commit df09bcb is NOT OK for suite deepsea:tier2.
Check tests results in the Jenkins job: http://storage-ci.suse.de:8080/job/pr-deepsea/156/

Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, this should also avoid having the old definitions hanging around. Maybe add a hint to remove any profile-* lines from policy.cfg?

In a post-upgrade scenario the user still has old-style profiles defined in the
pillar.

Since we don't force the user to move to the new drive-group implementation
right after the upgrade, we have to detect that they are running in 'legacy'
mode and stop.
@jschmid1 jschmid1 force-pushed the wip-post-upgrade-deploy branch from df09bcb to 21cdcef Compare April 25, 2019 11:25
@jschmid1
Copy link
Contributor Author

Makes sense, this should also avoid having the old definitions hanging around. Maybe add a hint to remove any profile-* lines from policy.cfg?

I added a placeholder for future references.. Only telling users to remove the profile line from the policy will probably result in a mess.

We have to have a proper document ready that describes the profiles -> drive-group migration process

@jschmid1
Copy link
Contributor Author

@susebot run teuthology

@susebot
Copy link
Collaborator

susebot commented Apr 25, 2019

Commit 21cdcef is OK for suite deepsea:tier2.
Check tests results in the Jenkins job: http://storage-ci.suse.de:8080/job/pr-deepsea/159/

@jschmid1 jschmid1 merged commit 719fbdc into SUSE:master Apr 25, 2019
@jschmid1
Copy link
Contributor Author

From here: #1629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants