Add tests for barclamp pacemaker #31
Conversation
aspiers
changed the title
| #device /dev/drbd-cct is chosen to avoid conflicts with | ||
| #other existing device paths on the nodes | ||
| @primary_node.exec!("open('/etc/drbd.d/cct_test1.res', 'w') { |f| | ||
| f << \"# Generated Manually for d52-54-02-77-77-02.virtual.cloud.suse.de\" |
There was a problem hiding this comment.
It would be nicer to get this from an external file, or at least use a heredoc.
|
In general this looks really awesome, thanks a lot! Other than my comments about DRY, I just have one overall observation at this point: the scenarios are really long. I don't think cucumber was supposed to be used like this. But maybe this is a deliberate choice to avoid lengthy setup for each scenario? If so is there any way to work around that? |
|
@aspiers: Thanks for the comments. I will refactor the code and submit the PR again. I do understand the scenarios are long, but i still feel they don't cover a few aspects. However, I think if we integrate CTS runs into mkcloud testsetup, then most of the tests in CCT can be eliminated OR yet another way could be to invoke pacemaker/CTS cases from CCT. |
|
To clarify: I am not at all objecting to these tests being comprehensive. I just wonder if they should be split up into a much larger number of smaller scenarios. AIUI best practice with cucumber is to have scenarios with not more than 5 or 6 steps. But I could be wrong. I'm also open to the idea of using CTS although I'd like to know what the advantages are. It's a much older testing framework than Cucumber so I expect it will have some disadvantages. |
mmnelemane
force-pushed
the
test-pacemaker
branch
3 times, most recently
from
71d6d9b
to
abbc46a
Compare
|
@aspiers: I tried to separate some of the tests to create 3 scenarios now. Regarding CTS, my understanding was that it is a more elaborate test suite that can be used for stress tests. And the advantage is that we need not maintain it ourselves and has community to support. However we can have CCT to do basic smoke tests and CTS for more regressive tests (not integrated into mkcloud testsetup currently). So in essence both CTS and CCT could exist for Pacemaker. |
mmnelemane
force-pushed
the
test-pacemaker
branch
from
abbc46a
to
99ef471
Compare
|
Yeah, that might make sense. I haven't looked too deeply into CTS yet. |
mmnelemane
force-pushed
the
test-pacemaker
branch
5 times, most recently
from
98c1967
to
3926c07
Compare
mmnelemane
force-pushed
the
test-pacemaker
branch
from
3926c07
to
8a3631f
Compare
Verifies deployment with basic tests for DRBD and CRM on the HA cluster.