Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sui-ssr] Remove deprecated stuff and prepare for new major version #1471

Open
rmoralp opened this issue Sep 29, 2022 · 0 comments
Open

[sui-ssr] Remove deprecated stuff and prepare for new major version #1471

rmoralp opened this issue Sep 29, 2022 · 0 comments
Labels
enhacement hacktoberfest

Comments

@rmoralp
Copy link
Contributor

rmoralp commented Sep 29, 2022

Package

New major version of @s-ui/ssr

Description

  • Remove sui-ssr archive bin and remove archiver dependency
  • Remove sui-ssr release bin and remove execa and git-url-parse dependencies
  • Refactor packages/sui-ssr/scripts/remove-tags.js in order to remove parse5 dependency (we could use some interpolation)

Bonus improvements:

  • Separate "hooks" middlewares into independent middleware files and add test coverage
  • Improve window.__INITIAL_DATA__ escaping. Check it in this page html window.__INITIAL_DATA__

⚠️ No new features are required

Additional Information

A @s-ui/ssr beta will be required for testing purpose on working projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhacement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmoralp