Skip to content
This repository has been archived by the owner on Apr 20, 2021. It is now read-only.

Font Sizes without px units #125

Open
davecarter opened this issue Oct 25, 2017 · 1 comment
Open

Font Sizes without px units #125

davecarter opened this issue Oct 25, 2017 · 1 comment
Assignees
Labels

Comments

@davecarter
Copy link
Contributor

Summary

When accessing to some of the Font Size Sass vars defined in settings due to their missing initialization in settings-compat-v7 the returning value has not pixel values.

The following missing values should be added to settings-compat-v7

$fz-xxxl: strip-unit(ceil($fz-base * 2.250)) * 1px !default;
$fz-xxxl: strip-unit(ceil($fz-base * 2.125)) * 1px !default;
$fz-xxl: strip-unit(ceil($fz-base * 2)) * 1px !default;
$fz-xs: strip-unit(ceil($fz-base * .5)) * 1px !default;
@davidbarna
Copy link
Contributor

You defined the same var twice and you defined fz-xs with a different value.
Can you check this code ?
Plus, when these variables added ??
When the migration was done, these were the font size variables:

// Font sizes
$fz-base: 14 !default;
$fz-body: $fz-base * 1px !default;
$fz-xs: ceil($fz-base * .666) * 1px !default;
$fz-s: ceil($fz-base * .8) * 1px !default;
$fz-m: $fz-base * 1px !default;
$fz-l: ceil($fz-base * 1.25) * 1px !default;
$fz-xl: ceil($fz-base * 1.75) * 1px !default;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants