Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts draft #3

Open
SThor opened this issue Jul 3, 2020 · 1 comment · May be fixed by #15
Open

Contracts draft #3

SThor opened this issue Jul 3, 2020 · 1 comment · May be fixed by #15

Comments

@SThor
Copy link
Owner

SThor commented Jul 3, 2020

No description provided.

SThor pushed a commit that referenced this issue Jul 7, 2020
@SThor
Copy link
Owner Author

SThor commented Jul 7, 2020

At the moment the contracts sit in the stage they're linked to, and we see all contracts of the current stage (and only of the current stage). I'm not sure at the moment if we'd like to see the smaller contracts of previous stages when we switch to a later one. Clearing everything not completed may be frustrating but at the same those contracts may simply be irrelevant.

We'll probably need at least four states to any contract in order to determine visibility:

  • not available yet
  • available
  • in progress
  • completed

(An additionnal failed state may be interesting, as well as something in betweeen available and unavailable : visible but greyed out if some condition is unmet)

Instead of grouping the contracts inside each stage object, maybe a better structure would be to have a big list of all contracts, and then filter them out in each of the four states, depending on properties like stage or other factors (if you've met a specific npc, if you have a specific upgrade in your base, etc.)

@SThor SThor linked a pull request Oct 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant