Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry without exception throwing #2

Open
arfl opened this issue Aug 12, 2019 · 1 comment
Open

Retry without exception throwing #2

arfl opened this issue Aug 12, 2019 · 1 comment
Labels
enhancement New feature or request
Projects
ex-tackle

Comments

@arfl
Copy link

arfl commented Aug 12, 2019 •
edited by kaikuchn
Loading

[Edit 02.01.2023]:

https://studitemps.atlassian.net/browse/FOT-1340

Die API der Library ist an dieser Stelle doof. Man muss dran denken, etwaige Fehler beim Handling von Events zu throwen, ansonsten greift der Retry-Mechanismus nicht.
@arfl arfl added this to To do in ex-tackle Jan 3, 2020
@arfl arfl added the enhancement New feature or request label Jan 3, 2020
@arfl arfl moved this from To do to Reviewer approved in ex-tackle Jan 5, 2020
@arfl arfl moved this from Reviewer approved to Done in ex-tackle Jan 5, 2020
@arfl arfl moved this from Done to Review in progress in ex-tackle Jan 6, 2020
@arfl arfl moved this from Review in progress to In progress in ex-tackle Jan 6, 2020
@arfl arfl moved this from In progress to Reviewer approved in ex-tackle Jul 6, 2020
@kaikuchn
Copy link

We first want to migrate our EventConsumers away from throwing retries by themselves. We achieve this by having the Shared.EventConsumer implementation handle throwing on error results. In a follow-up step we can then rewrite the retry mechanism to trigger a retry on error tuple results without any throwing and only need to change the Shared.EventConsumer to no longer throw anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ex-tackle
  
Reviewer approved
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arfl @kaikuchn