Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug found in HAL_NAND_Read_Page_8b and HAL_NAND_Read_SpareArea_8b #6

Closed
huoxingdawang opened this issue Sep 7, 2023 · 1 comment · Fixed by #7
Closed

Bug found in HAL_NAND_Read_Page_8b and HAL_NAND_Read_SpareArea_8b #6

huoxingdawang opened this issue Sep 7, 2023 · 1 comment · Fixed by #7
Assignees
@TOUNSTM
Labels
bug Something isn't working duplicate This issue or pull request already exists hal HAL-LL driver-related issue or pull-request.
Milestone
v1.3.2

Comments

@huoxingdawang
Copy link
Contributor

huoxingdawang commented Sep 7, 2023 •
edited
Loading

The code for reading data from the NAND Flash in the stm32f7xx_hal_nand.c is *buff = *(uint8_t *)deviceaddress; rather than *(__IO uint8_t *)deviceaddress; which may cause the data always to be the first data read from the nand flash when code is optimized by the compiler.

https://github.com/STMicroelectronics/stm32f7xx_hal_driver/blob/a89b85ba16ab07f42165ca67949c0366a9ea1c3a/Src/stm32f7xx_hal_nand.c#L638

https://github.com/STMicroelectronics/stm32f7xx_hal_driver/blob/a89b85ba16ab07f42165ca67949c0366a9ea1c3a/Src/stm32f7xx_hal_nand.c#L1288

And the bug is still exists in this version:
image
@huoxingdawang huoxingdawang mentioned this issue Sep 7, 2023
Merged
@huoxingdawang
Copy link
Contributor Author

I created PR #7 to fix this bug.

@huoxingdawang huoxingdawang mentioned this issue Sep 7, 2023
Closed
@ALABSTM ALABSTM added hal HAL-LL driver-related issue or pull-request. bug Something isn't working labels Sep 15, 2023
@ALABSTM ALABSTM linked a pull request Sep 15, 2023 that will close this issue
Fix the bug that HAL_NAND_Read_Page_8b and HAL_NAND_Read_SpareArea_8b cannot read data normally. #7
Merged
@TOUNSTM TOUNSTM added the duplicate This issue or pull request already exists label Dec 15, 2023
@TOUNSTM TOUNSTM added this to the v1.3.2 milestone May 27, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in stm32cube-mcu-hal-dashboard Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TOUNSTM TOUNSTM

Labels
bug Something isn't working duplicate This issue or pull request already exists hal HAL-LL driver-related issue or pull-request.
Projects
stm32cube-mcu-hal-dashboard
Status: Done
Milestone
v1.3.2
3 participants
@huoxingdawang @ALABSTM @TOUNSTM