Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in stm32f7xx_hal_hcd.c using callback #2

Closed
micheledarold opened this issue Jun 24, 2021 · 5 comments
Closed

Bug in stm32f7xx_hal_hcd.c using callback #2

micheledarold opened this issue Jun 24, 2021 · 5 comments
Assignees
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb Universal Serial Bus
Milestone

Comments

@micheledarold
Copy link

Missing use of registered callback in some part of the code.

I have enabled USE_HAL_HCD_REGISTER_CALLBACKS but I find some part of the code not using the correct way to call the function
HAL_HCD_HC_NotifyURBChange_Callback.
hcd_patch.txt

@ALABSTM ALABSTM self-assigned this Jun 28, 2021
@ALABSTM ALABSTM added hal HAL-LL driver-related issue or pull-request. usb Universal Serial Bus labels Jun 28, 2021
@ALABSTM ALABSTM added bug Something isn't working needs clarification Needs clarification or inputs from the user labels Aug 9, 2021
@ALABSTM
Copy link
Collaborator

ALABSTM commented Aug 9, 2021

Hi @micheledarold,

Thank you for this report. Your point is correct. It will be forwarded to our development teams. May I ask you first to create a pull-request? This will allow a far more easy way to view the changes proposed. Thank you very much.

With regards,

@ALABSTM ALABSTM added internal bug tracker Issue confirmed and logged into the internal bug tracking system and removed needs clarification Needs clarification or inputs from the user labels Aug 11, 2021
@ALABSTM
Copy link
Collaborator

ALABSTM commented Aug 11, 2021

ST Internal Reference: 111775

@ALABSTM
Copy link
Collaborator

ALABSTM commented Aug 11, 2021

Hi @micheledarold,

The issue you reported has been forwarded to our development teams. No more need to create a pull-request this time. Next times maybe, as it allows to visualize the changes far more easily and, more important, to integrate them faster into the repository. Thank you again for having reported this one.

With regards,

@micheledarold
Copy link
Author

micheledarold commented Aug 23, 2021

Hi @ALABSTM I'm on vacation and back in office only today, so thank you for your help, next time I'll provide the pull request.

@ALABSTM ALABSTM added this to the v1.2.10 milestone Nov 15, 2021
@ALABSTM
Copy link
Collaborator

ALABSTM commented Dec 15, 2021

Hi @micheledarold,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.2.10 of the stm32f7xx_hal_driver published recently on GitHub. Thank you again for having reported.

With regards,

@ALABSTM ALABSTM closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb Universal Serial Bus
Projects
None yet
Development

No branches or pull requests

2 participants