Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky / failing unit tests #124

Open
pyby opened this issue Jul 8, 2023 · 1 comment · Fixed by #125
Open

Flaky / failing unit tests #124

pyby opened this issue Jul 8, 2023 · 1 comment · Fixed by #125
Labels
maintenance minor bug

Comments

@pyby
Copy link
Member

pyby commented Jul 8, 2023

Some unit tests are flaky on CI only. Passed with Xcode UI:

For one, using Xcode 14.3, the Mac OS update from teamcity.agent.jvm.os.version 13.3.1 to 13.4 :

  • testNonStreamedMediaPlayback
pyby added a commit that referenced this issue Jul 8, 2023
@pyby
Disable flaky test
ef238b2 
Documented in issue #124
@pyby pyby mentioned this issue Jul 8, 2023
Merged
3 tasks
@pyby pyby linked a pull request Jul 8, 2023 that will close this issue
Disable flaky test #125
Merged
3 tasks
@pyby pyby closed this as completed in #125 Jul 8, 2023
@pyby pyby reopened this Jul 8, 2023
@pyby
Copy link
Member Author

pyby commented Jul 8, 2023

To try with command line:
xcodebuild test -scheme SRGMediaPlayer -destination 'platform=iOS Simulator,name=iPhone 14 Pro' -only-testing 'SRGMediaPlayerTests/PlaybackTestCase/testNonStreamedMediaPlayback'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance minor bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable flaky test SRGSSR/srgmediaplayer-apple
1 participant
@pyby