Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SRGSSR/srgidentity-apple
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.0.4
Choose a base ref
...
head repository: SRGSSR/srgidentity-apple
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing with 391 additions and 387 deletions.
  1. +3 −1 .gitignore
  2. +2 −3 .rubocop.yml
  3. +17 −0 .swiftlint.yml
  4. +2 −2 Demo/Demo.xcconfig
  5. +3 −3 Demo/SRGIdentity-demo.xcodeproj/project.pbxproj
  6. +1 −1 Demo/SRGIdentity-demo.xcodeproj/xcshareddata/xcschemes/SRGIdentity-demo.xcscheme
  7. +14 −14 Demo/SRGIdentity-demo.xcworkspace/xcshareddata/swiftpm/Package.resolved
  8. +1 −0 Demo/Sources/Application/AppDelegate.h
  9. +6 −4 Demo/Sources/Application/AppDelegate.m
  10. +0 −3 Gemfile
  11. +102 −91 Gemfile.lock
  12. +14 −14 Package.resolved
  13. +6 −6 Package.swift
  14. +1 −1 Sources/SRGIdentity/SRGIdentityLoginViewController.h
  15. +10 −10 Sources/SRGIdentity/SRGIdentityLoginViewController~tvos.m
  16. +9 −3 Sources/SRGIdentity/SRGIdentityModalTransition~ios.m
  17. +9 −6 Sources/SRGIdentity/SRGIdentityNavigationController~ios.m
  18. +23 −74 Sources/SRGIdentity/SRGIdentityService.m
  19. +19 −52 Sources/SRGIdentity/SRGIdentityWebViewController~ios.m
  20. +17 −0 Sources/SRGIdentity/UIApplication+SRGIdentity.h
  21. +19 −0 Sources/SRGIdentity/UIApplication+SRGIdentity.m
  22. +13 −15 Sources/SRGIdentity/include/SRGIdentityService.h
  23. +5 −1 Tests/SRGIdentity-tests.xcodeproj/project.pbxproj
  24. +1 −1 Tests/SRGIdentity-tests.xcodeproj/xcshareddata/xcschemes/SRGIdentity-tests.xcscheme
  25. +16 −16 Tests/SRGIdentity-tests.xcworkspace/xcshareddata/swiftpm/Package.resolved
  26. +1 −1 Tests/Tests.xcconfig
  27. +15 −19 docs/GETTING_STARTED.md
  28. +1 −1 docs/README.md
  29. +46 −26 fastlane/Fastfile
  30. +0 −7 fastlane/Pluginfile
  31. +15 −12 fastlane/README.md
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -12,4 +12,6 @@ xcuserdata
/fastlane/*.xml

/vendor
/.bundle
/.bundle

.vscode
5 changes: 2 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -4,16 +4,15 @@ inherit_mode:

AllCops:
Exclude:
- 'Carthage/**/*'
- 'Demo/Carthage/**/*'
- 'vendor/**/*'
Include:
- 'fastlane/Pluginfile'
NewCops: enable

# this would cause errors with long lanes
Metrics/BlockLength:
Enabled: true
ExcludedMethods: ['platform', 'for_platform']
IgnoredMethods: ['platform', 'for_platform']

# Lane description and gem lines can be long
Layout/LineLength:
17 changes: 17 additions & 0 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
disabled_rules:
- identifier_name
- statement_position
- todo

line_length: 300

trailing_whitespace:
ignores_empty_lines: true
severity: warning

nesting:
type_level: 2

excluded:
- .build
- vendor
4 changes: 2 additions & 2 deletions Demo/Demo.xcconfig
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Version information
MARKETING_VERSION = 3.0.4
MARKETING_VERSION = 3.3.0

// Deployment targets
IPHONEOS_DEPLOYMENT_TARGET = 9.0
IPHONEOS_DEPLOYMENT_TARGET = 12.0
TVOS_DEPLOYMENT_TARGET = 12.0

// Configuration to have a single target built for all platforms
6 changes: 3 additions & 3 deletions Demo/SRGIdentity-demo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -186,7 +186,7 @@
6F0EB52820FC7F58009C02CF /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 1240;
LastUpgradeCheck = 1400;
ORGANIZATIONNAME = "SRG SSR";
TargetAttributes = {
6F8A93D720FDCA0800AA6434 = {
@@ -288,6 +288,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
@@ -350,6 +351,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
@@ -374,7 +376,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 6F0402F4233131AE00DA4D97 /* Demo.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = "$(APP_ICONS_SOURCE)";
CODE_SIGN_ENTITLEMENTS = Demo.entitlements;
DEVELOPMENT_TEAM = VMGRRW6SG7;
INFOPLIST_FILE = Info.plist;
@@ -391,7 +392,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 6F0402F4233131AE00DA4D97 /* Demo.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = "$(APP_ICONS_SOURCE)";
CODE_SIGN_ENTITLEMENTS = Demo.entitlements;
DEVELOPMENT_TEAM = VMGRRW6SG7;
INFOPLIST_FILE = Info.plist;
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1400"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Original file line number Diff line number Diff line change
@@ -6,62 +6,62 @@
"repositoryURL": "https://github.com/SRGSSR/FXReachability.git",
"state": {
"branch": null,
"revision": "1eac916df0045630e779fa60eef22ed0d185e15f",
"version": "1.3.2-srg5"
"revision": "b8d60cfbe6eddf1a622476548465efed88afb564",
"version": "1.3.2-srg6"
}
},
{
"package": "libextobjc",
"repositoryURL": "https://github.com/SRGSSR/libextobjc.git",
"state": {
"branch": null,
"revision": "30ee5b73bdf57a826978aa146881277f22369be1",
"version": "0.6.0-srg3"
"revision": "9c9a7327410fe3f7cdb695965ced43b9a7766ee0",
"version": "0.6.0-srg4"
}
},
{
"package": "MAKVONotificationCenter",
"repositoryURL": "https://github.com/SRGSSR/MAKVONotificationCenter.git",
"state": {
"branch": null,
"revision": "60395e0601ffd4a784856b423d4cac558366276d",
"version": "1.0.0-srg5"
"revision": "8bde3cdc872085bd31f4cfe546bdf8e6932a0806",
"version": "1.0.0-srg6"
}
},
{
"package": "Mantle",
"repositoryURL": "https://github.com/Mantle/Mantle.git",
"state": {
"branch": null,
"revision": "eb4ad298d81c023bcba20810ceffba695378ded4",
"version": "2.1.6"
"revision": "16f72bfe72a2ab29654ba894da1c32b17524e1a6",
"version": "2.2.0"
}
},
{
"package": "SRGAppearance",
"repositoryURL": "https://github.com/SRGSSR/srgappearance-apple.git",
"state": {
"branch": null,
"revision": "48258a788952348c7fa38b5b8e9181b25f3c87b8",
"version": "3.0.0"
"revision": "72d9475b46d97ecde0298b5bc80a654e8b424ebb",
"version": "5.2.0"
}
},
{
"package": "SRGLogger",
"repositoryURL": "https://github.com/SRGSSR/srglogger-apple.git",
"state": {
"branch": null,
"revision": "cfc39d1223ed039aeb7df38c6c7570977b22d1aa",
"version": "3.0.0"
"revision": "dd98468422044b53e283d970809b8502e1ef5b8d",
"version": "3.1.0"
}
},
{
"package": "SRGNetwork",
"repositoryURL": "https://github.com/SRGSSR/srgnetwork-apple.git",
"state": {
"branch": null,
"revision": "734fe399088b2f846e9e69d48a43118f6a8dc0d2",
"version": "3.0.0"
"revision": "153a2544391c1aaccae2d38d8b113fd0a03421b8",
"version": "3.1.0"
}
},
{
1 change: 1 addition & 0 deletions Demo/Sources/Application/AppDelegate.h
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@ NS_ASSUME_NONNULL_BEGIN

@interface AppDelegate : UIResponder <UIApplicationDelegate>

// TODO: Remove when SRG Analytics demo requires iOS 13
@property (nonatomic) UIWindow *window;

@end
10 changes: 6 additions & 4 deletions Demo/Sources/Application/AppDelegate.m
Original file line number Diff line number Diff line change
@@ -16,9 +16,6 @@ @implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
self.window = [[UIWindow alloc] initWithFrame:UIScreen.mainScreen.bounds];
[self.window makeKeyAndVisible];

SRGIdentityService.currentIdentityService = [[SRGIdentityService alloc] initWithWebserviceURL:[NSURL URLWithString:@"https://hummingbird.rts.ch/api/profile"]
websiteURL:[NSURL URLWithString:@"https://www.rts.ch/profile"]];

@@ -27,7 +24,12 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
name:SRGIdentityServiceUserDidLogoutNotification
object:SRGIdentityService.currentIdentityService];

self.window.rootViewController = ApplicationRootViewController();
if (@available(iOS 13, tvOS 13, *)) {}
else {
self.window = [[UIWindow alloc] initWithFrame:UIScreen.mainScreen.bounds];
[self.window makeKeyAndVisible];
self.window.rootViewController = ApplicationRootViewController();
}
return YES;
}

3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -8,6 +8,3 @@ source 'https://rubygems.org'

gem 'fastlane'
gem 'xcode-install'

plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
eval_gemfile(plugins_path) if File.exist?(plugins_path)
Loading