Updated test objects names to be more descriptive.

Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>

Author: davem-bis

tests/core/test_snapshot.py

@@ -2408,77 +2408,97 @@ def test_earliest_start_date(sushi_context: Context):
 
 def test_deployability_index(make_snapshot):
     # Breaking change - should be both representantive / deployable
-    snapshot_a = make_snapshot(SqlModel(name="a", query=parse_one("SELECT 1")))
-    snapshot_a.categorize_as(SnapshotChangeCategory.BREAKING)
+    snapshot_breaking = make_snapshot(SqlModel(name="a", query=parse_one("SELECT 1")))
+    snapshot_breaking.categorize_as(SnapshotChangeCategory.BREAKING)
 
     # Forward only breaking change - cannot be representative / deployable due to forward only
-    snapshot_b = make_snapshot(SqlModel(name="b", query=parse_one("SELECT 1")))
-    snapshot_b.categorize_as(SnapshotChangeCategory.BREAKING, forward_only=True)
-    snapshot_b.parents = (snapshot_a.snapshot_id,)
+    snapshot_breaking_forward_only = make_snapshot(SqlModel(name="b", query=parse_one("SELECT 1")))
+    snapshot_breaking_forward_only.categorize_as(SnapshotChangeCategory.BREAKING, forward_only=True)
+    snapshot_breaking_forward_only.parents = (snapshot_breaking.snapshot_id,)
 
     # Indirect breaking - cannot be representative / deployable due to forward only non-deployable parent
-    snapshot_c = make_snapshot(SqlModel(name="c", query=parse_one("SELECT 1")))
-    snapshot_c.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
-    snapshot_c.parents = (snapshot_b.snapshot_id,)
+    snapshot_indirect_breaking_1 = make_snapshot(SqlModel(name="c", query=parse_one("SELECT 1")))
+    snapshot_indirect_breaking_1.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
+    snapshot_indirect_breaking_1.parents = (snapshot_breaking_forward_only.snapshot_id,)
 
     # Indirect breaking - cannot be representative / deployable due to forward only non-deployable parent
-    snapshot_d = make_snapshot(SqlModel(name="d", query=parse_one("SELECT 1")))
-    snapshot_d.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
-    snapshot_d.parents = (snapshot_b.snapshot_id, snapshot_a.snapshot_id)
+    snapshot_indirect_breaking_2 = make_snapshot(SqlModel(name="d", query=parse_one("SELECT 1")))
+    snapshot_indirect_breaking_2.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
+    snapshot_indirect_breaking_2.parents = (
+        snapshot_breaking_forward_only.snapshot_id,
+        snapshot_breaking.snapshot_id,
+    )
 
     # Non breaking - representative / deployable due to no breaking changes
-    snapshot_e = make_snapshot(SqlModel(name="e", query=parse_one("SELECT 1")))
-    snapshot_e.categorize_as(SnapshotChangeCategory.NON_BREAKING)
+    snapshot_non_breaking = make_snapshot(SqlModel(name="e", query=parse_one("SELECT 1")))
+    snapshot_non_breaking.categorize_as(SnapshotChangeCategory.NON_BREAKING)
 
     # Indirect breaking - can be representative / deployable due to deployable parents
-    snapshot_f = make_snapshot(SqlModel(name="f", query=parse_one("SELECT 1")))
-    snapshot_f.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
-    snapshot_f.parents = (snapshot_e.snapshot_id, snapshot_a.snapshot_id)
+    snapshot_indirect_breaking_deployable_parents = make_snapshot(
+        SqlModel(name="f", query=parse_one("SELECT 1"))
+    )
+    snapshot_indirect_breaking_deployable_parents.categorize_as(
+        SnapshotChangeCategory.INDIRECT_BREAKING
+    )
+    snapshot_indirect_breaking_deployable_parents.parents = (
+        snapshot_non_breaking.snapshot_id,
+        snapshot_breaking.snapshot_id,
+    )
 
     # Indirect non breaking - cannot be representative / deployable due to possible data drift from prod
-    snapshot_g = make_snapshot(SqlModel(name="g", query=parse_one("SELECT 1")))
-    snapshot_g.intervals = [(to_timestamp("2023-01-01"), to_timestamp("2023-01-02"))]
-    snapshot_g.categorize_as(SnapshotChangeCategory.INDIRECT_NON_BREAKING)
-    snapshot_g.parents = (snapshot_e.snapshot_id,)
-    
+    snapshot_indirect_non_breaking = make_snapshot(SqlModel(name="g", query=parse_one("SELECT 1")))
+    snapshot_indirect_non_breaking.intervals = [
+        (to_timestamp("2023-01-01"), to_timestamp("2023-01-02"))
+    ]
+    snapshot_indirect_non_breaking.categorize_as(SnapshotChangeCategory.INDIRECT_NON_BREAKING)
+    snapshot_indirect_non_breaking.parents = (snapshot_non_breaking.snapshot_id,)
+
     # Indirect breaking - cannot be representative / deployable due to indirect non breaking non-deployable parent
-    snapshot_h = make_snapshot(SqlModel(name="h", query=parse_one("SELECT 1")))
-    snapshot_h.categorize_as(SnapshotChangeCategory.INDIRECT_BREAKING)
-    snapshot_h.parents = (snapshot_g.snapshot_id,)
+    snapshot_indirect_breaking_non_deployable_parents = make_snapshot(
+        SqlModel(name="h", query=parse_one("SELECT 1"))
+    )
+    snapshot_indirect_breaking_non_deployable_parents.categorize_as(
+        SnapshotChangeCategory.INDIRECT_BREAKING
+    )
+    snapshot_indirect_breaking_non_deployable_parents.parents = (
+        snapshot_indirect_non_breaking.snapshot_id,
+    )
 
     snapshots = {
         s.snapshot_id: s
         for s in [
-            snapshot_a,
-            snapshot_b,
-            snapshot_c,
-            snapshot_d,
-            snapshot_e,
-            snapshot_f,
-            snapshot_g,
-            snapshot_h,
+            snapshot_breaking,
+            snapshot_breaking_forward_only,
+            snapshot_indirect_breaking_1,
+            snapshot_indirect_breaking_2,
+            snapshot_non_breaking,
+            snapshot_indirect_breaking_deployable_parents,
+            snapshot_indirect_non_breaking,
+            snapshot_indirect_breaking_non_deployable_parents,
         ]
     }
 
     deployability_index = DeployabilityIndex.create(snapshots)
 
-    assert deployability_index.is_deployable(snapshot_a)
-    assert deployability_index.is_deployable(snapshot_e)
-    assert deployability_index.is_deployable(snapshot_f)
-    assert not deployability_index.is_deployable(snapshot_b)
-    assert not deployability_index.is_deployable(snapshot_c)
-    assert not deployability_index.is_deployable(snapshot_d)
-    assert not deployability_index.is_deployable(snapshot_g)
-    assert not deployability_index.is_deployable(snapshot_h)
-
-    assert deployability_index.is_representative(snapshot_a)
-    assert deployability_index.is_representative(snapshot_e)
-    assert deployability_index.is_representative(snapshot_f)
-    assert not deployability_index.is_representative(snapshot_b)
-    assert not deployability_index.is_representative(snapshot_c)
-    assert not deployability_index.is_representative(snapshot_d)
-    assert not deployability_index.is_representative(snapshot_g)
-    assert not deployability_index.is_representative(snapshot_h)
+    assert deployability_index.is_deployable(snapshot_breaking)
+    assert deployability_index.is_deployable(snapshot_non_breaking)
+    assert deployability_index.is_deployable(snapshot_indirect_breaking_deployable_parents)
+    assert not deployability_index.is_deployable(snapshot_breaking_forward_only)
+    assert not deployability_index.is_deployable(snapshot_indirect_breaking_1)
+    assert not deployability_index.is_deployable(snapshot_indirect_breaking_2)
+    assert not deployability_index.is_deployable(snapshot_indirect_non_breaking)
+    assert not deployability_index.is_deployable(snapshot_indirect_breaking_non_deployable_parents)
+
+    assert deployability_index.is_representative(snapshot_breaking)
+    assert deployability_index.is_representative(snapshot_non_breaking)
+    assert deployability_index.is_representative(snapshot_indirect_breaking_deployable_parents)
+    assert not deployability_index.is_representative(snapshot_breaking_forward_only)
+    assert not deployability_index.is_representative(snapshot_indirect_breaking_1)
+    assert not deployability_index.is_representative(snapshot_indirect_breaking_2)
+    assert not deployability_index.is_representative(snapshot_indirect_non_breaking)
+    assert not deployability_index.is_representative(
+        snapshot_indirect_breaking_non_deployable_parents
+    )
 
     all_deployable_index = deployability_index.all_deployable()
     assert all(all_deployable_index.is_deployable(s) for s in snapshots.values())