Add typing indicators to subtle #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/mob/living/silicon/robot/update_icons() is called periodically by Life(), and was removing the typing indicator overlay.
Test Merge Removed |
3 tasks
|
handled by #727 |
Test Merge Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR adds a verb "Subtle-with-indicator", equivalent to subtle but with typing indicators.
Fixes #494
Why It's Good For The Game
Typing indicators are essential for long-winded RP to let the other person know that you are working on your post. Should someone not want them they can always use the regular Subtle verb, which this PR does not touch.
Pre-Merge Checklist
Changelog
🆑
add: Typing indicators have been added to subtle! Note that you may need to update your keybindings to use them(To do so: Character Settings->Keybindings, and then either reset to default at the bottom, or manually bind things to your liking, the new verb is found under the communication group.)
:fix: Borg Typing indicators work again.
/:cl: