Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis labeling in plot function #16

Open
ltdeck opened this issue Oct 5, 2021 · 5 comments
Open

Axis labeling in plot function #16

ltdeck opened this issue Oct 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@ltdeck
Copy link
Member

ltdeck commented Oct 5, 2021

The plot() function currently does not autogenerate physically meaningful labels for the x- and y-axis. This may impact the user experience. For the example below, that shows a box plot of simulated nucleation temperatures, I would recommend the following:
x-label: "vial position"
y-label: "nucleation temperature [°C]"

Ideally, the function would autogenerate such labels depending on the type of plot.

labeling

@bizzinho bizzinho added the enhancement New feature or request label Oct 5, 2021
@bizzinho
Copy link
Member

bizzinho commented Oct 5, 2021

Need to check but I believe opcond is unit agnostic. This would mean time unit cannot be necessarily inferred.

@bizzinho
Copy link
Member

bizzinho commented Oct 5, 2021

Indeed it is agnostic, could be Fahrenheit per ms for all opcond (and therefore Snowflake?) cares. So need to discuss what is the best way to do this without imposing some default on the user that they might not expect.

@ltdeck
Copy link
Member Author

ltdeck commented Oct 6, 2021

With respect to the default I would argue that by providing values, we always impose some default. E.g., the temperature values provided are clearly in °C, independent of whether we add the label or not. Ideally, we could add the option to choose the unit when plotting (i.e., °C,°F,K for temperature).

@ltdeck
Copy link
Member Author

ltdeck commented Oct 6, 2021

As default, I would suggest to follow the unit definitions in the operating conditions, i.e. seconds for time and °C for temperature.

@bizzinho
Copy link
Member

bizzinho commented Oct 6, 2021

We can make this design choice, but we must be aware that it might affect users who would have preferred different base units somewhat negatively. And we will have to provide a framework for changing units easily. You could do this within the plot function only, but a more sustainable solution is probably to give the class itself some way of knowing about its units (ie by having them as attributes).

@bizzinho bizzinho added this to To do in 3D model (1.1) Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants